Botbar displaying hours instead of the day when timeframe is day, using timezone

Botbar displays the candle’s time as hours when the timezone is set and time frame is day:

I could see there’s a condition on botbar.js at format_date function, enabling timezones only for tf less than a day

    format_date(p) {
        let t = p[1][0]
        t = this.grid_0.ti_map.i2t(t)
        let ti = this.$p.layout.grids[0].ti_map.tf
        // Enable timezones only for tf < 1D
        let k = ti < DAY ? 1 : 0
        let tZ = t + k * this.$p.timezone * HOUR
        //t += new Date(t).getTimezoneOffset() * MINUTE
        let d = new Date(tZ)
        if (p[2] === YEAR || Utils.year_start(t) === t) {
            return d.getUTCFullYear()
        }
        if (p[2] === MONTH || Utils.month_start(t) === t) {
            return MONTHMAP[d.getUTCMonth()]
        }
        // TODO(*) see grid_maker.js
        if (Utils.day_start(tZ) === tZ) return d.getUTCDate()
        let h = Utils.add_zero(d.getUTCHours())
        let m = Utils.add_zero(d.getUTCMinutes())
        return h + ":" + m
    }

But when a timeframe is set (in my case -3) the bot bar shows 03:00, which probably is not considered on this algorithm when Utils.day_start(tZ) is not equal to tZ, once the function to get the first day considering the tZ passed as UTC time, which is not the case.

So, Is this an easy fix to do just enabling timezones for tf also greater than 1D?

[C451]

The main problem is that the samplers do not support non-UTC candle closes (including different exchange closing times, unequal month lengths etc), so as I mentioned I need to spend some time thinking about it.

[adsonvinicius]

Hi Arul, I was using the code-change I mentioned above but as the author said it was a little bit more complicated so I was waiting for an improvement. However the library is not updated as before anymore, so I would recommend you to try what I did.

On Thu, Jul 8, 2021 at 5:33 PM Arul @.***> wrote:

Hello adson , did you find any solution for this, the library is using UTC , but we need our local TZ

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tvjsx/trading-vue-js/issues/158#issuecomment-876727987, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRAKW76TUHZ4RJWSP2EAADTWYDTBANCNFSM4TVJOKIQ .

– Atenciosamente,

Adson Damasceno