question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Button Group classes are missing border-radius properties

See original GitHub issue

The Button Group (btn-group) classes are missing border-radius values. While the Buttons (btn) contained within the Button Group have their own border radius values, the Button Group itself also needs matching values. The problem is not apparent until a Shadow class is applied to a Button Group.

Applying a shadow or shadow-lg class to the btn-group produces a Button Group with a squared off white corners showing on all four corners of the Button Group, like so:

127210855-73e183d2-f5ca-448e-bf20-be52b7194919

To remedy this we just need to add border-radius values to the following classes:

  • btn-group : 0.25rem
  • btn-group-sm : 0.2rem
  • btn-group-lg : 0.3rem

Doing so fixes the problem and eliminates the squared off corners of the btn-group, producing a Button group with the desired results:

CleanShot 2021-07-27 at 14 57 25@2x

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
AndyJiang99commented, Dec 13, 2021

Hey @XhmikosR , opened a PR (#35467) to address this issue. I wasn’t able to add a reviewer directly on the PR so I figured this might be a better way to bring your attention to this. Thanks! 😃

Can I work with you on this?

Thanks for reaching out. I think the PR is pretty much done now, just waiting for approval for it to be merged into the main branch so this issue should be good to go. I don’t think there is anything else to do, so I don’t need help for anything for this issue. Thanks anyways though

0reactions
Darkace01commented, Dec 9, 2021

Hey @XhmikosR , opened a PR (#35467) to address this issue. I wasn’t able to add a reviewer directly on the PR so I figured this might be a better way to bring your attention to this. Thanks! 😃

Can I work with you on this?

Read more comments on GitHub >

github_iconTop Results From Across the Web

html - Button Group Border Radius issue - Stack Overflow
It works for when there is more than one button, but when there is only one button, the button doesn't have rounded corners...
Read more >
Missing border radius on input group with validation feedback
It would be impossible. I think we should move .invalid-feedback to outside of input group. And then, extend .input-group class ( ...
Read more >
border-radius - CSS: Cascading Style Sheets - MDN Web Docs
The border-radius CSS property rounds the corners of an element's outer border edge. You can set a single radius to make circular corners, ......
Read more >
border-radius - CSS-Tricks
The border-radius property takes between one and four length or percentage values, where one value sets the radius for all four corners at...
Read more >
Borders - Bootstrap
Great for images, buttons, or any other element. Border. Use border utilities to add or remove an element's borders. Choose from all borders...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found