question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Docs: carousel, collapse, navs (tabs), popovers should use buttons rather than faked link buttons

See original GitHub issue

There’s no good reason (other than ease of styling) for https://v5.getbootstrap.com/docs/5.0/components/carousel/, https://v5.getbootstrap.com/docs/5.0/components/collapse/, https://v5.getbootstrap.com/docs/5.0/components/navs/#javascript-behavior, https://v5.getbootstrap.com/docs/5.0/components/popovers/#dismiss-on-next-click to use <a href="#..." role="button">...</a> pseudo-buttons. While sure, BS can still support this, it’d be good to lead by example and use the correct <button> element for this (though I don’t believe we have a neutral-enough button style out of the box to support carousel buttons…or at least, the current carousel controls need to be extended to neutralise the remaining button styles that creep in when swapping out the elements).

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:2
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
patrickhlaukecommented, Feb 9, 2021

Closing this as - apart from popovers using links, which is still necessary with our current approach due to Safari/macOS’s odd duck behaviour, copied by Firefox/macOS - all major things are now sorted.

1reaction
XhmikosRcommented, Sep 26, 2020

We don’t assign issues to people and there’s no need to ask for permission 😃 Just grab an issue, work on it and make a PR when ready.

Read more comments on GitHub >

github_iconTop Results From Across the Web

JavaScript · Bootstrap
To keep URLs intact with link buttons, use the data-target attribute instead of href="#" . <div class="dropdown"> <a id=" ...
Read more >
Bootstrap 4 Tutorial - W3Schools
This Bootstrap 4 tutorial contains hundreds of Bootstrap 4 examples. With our online editor, you can edit the code, and click on a...
Read more >
Bootstrap Tabs - examples & tutorial
Responsive Tabs built with Bootstrap 5. Examples of vertical tabs, tab panel, tabs justified, filled, with buttons, and many other variations of the...
Read more >
usability – ACRL TechConnect - American Library Association
Carousels are a popular website feature because they allow one to fit extra information within the same footprint and provide visual interest on...
Read more >
Introduction to Bootstrap Training - Webucator
You can get started using Bootstrap with nothing more than a code editor and a browser. ... <button class="nav-item nav-link active" id="paul-tab".
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found