Release 5.2.0 does not have color-adjust deprecation fix
See original GitHub issuePrerequisites
- I have searched for duplicate or closed issues
- I have validated any HTML to avoid common problems
- I have read the contributing guidelines
Describe the issue
As you can see, a PR was merged which removes the color-adjust
property inside of the _form-check.scss
file for the rule .form-check-input
here.
However, I import the compiled CSS files in my projects because I am using Autoprefixer and PostCSS. I import CSS like this:
import 'bootstrap/dist/css/bootstrap.css';
As you can see in the compiled CSS file, color-adjust
is still there: https://github.com/twbs/bootstrap/blob/main/dist/css/bootstrap.css#L2274
Furthermore, looking in the SCSS
directory inside of my node_modules
directory is showing that the color-adjust
property has been removed from the scss
file also. But, it’s in the compiled CSS file.
So, either something has gone astray during the build process, or a tool is adding color-adjust
. As a result, in my application that uses Autoprefixer 10.4.7, I am getting the warning: autoprefixer: Replace color-adjust to print-color-adjust. The color-adjust shorthand is currently deprecated.
which is tripping up my continuous integration builds as warnings are considered errors in production release environments.
I looked through the releases for 5.2 beta and 5.2 and could see no fixes for this issue mentioned in the notes.
Reduced test cases
Numerous cases have already been outlined in previously closed issues:
What operating system(s) are you seeing the problem on?
Windows, macOS, Linux
What browser(s) are you seeing the problem on?
No response
What version of Bootstrap are you using?
5.2.0
Issue Analytics
- State:
- Created a year ago
- Reactions:3
- Comments:6 (4 by maintainers)
Top GitHub Comments
Good news, it’s been fixed in
autoprefixer
10.4.8. Dependency version will be updated in Bootstrap. In your projects, you probably can force it to use the 10.4.8 so that the warning message disappears while waiting for our next release.Some extra-information about this issue. With Autoprefixer 10.4.7, there are some cases where
color-adjust: exact;
is added.It can be tested directly in https://autoprefixer.github.io/.
As an example:
browserlist
,color-adjust: exact
is not added..browserlistrc
(last 2 major versions, not dead, Chrome >= 60, Firefox >= 60, Firefox ESR, iOS >= 12, Safari >= 12, not Explorer <= 11
),color-adjust: exact
is added..browserlistrc
(last 2 major versions, not dead, Chrome >= 60, iOS >= 12, Safari >= 12, not Explorer <= 11
),color-adjust: exact
is not added.If we change
autoprefixer
version in ourpackage.json
without changing our.browserlistrc
:-webkit-print-color-adjust: exact;
and-moz-print-color-adjust: exact;
are added-webkit-print-color-adjust: exact;
andcolor-adjust: exact;
are addedWe can see a warning message in our proper build when we run
css-rtl
. It makes run a second time PostCSS + Autoprefixer. That must be the same issue if a user run PostCSS + Autoprefixer on something based on the CSS file we deliver and that containscolor-adjust: exact;
.I still doesn’t understand why in one hand
color-adjust: exact
is added to support Firefox < 97 and on the other hand, a file already containing acolor-adjust: exact
to support Firefox < 97 generates a warning.