question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rename close icon class to btn-close

See original GitHub issue

Imo:

  1. close name is very generic, but adds a lot of styling and interferes with any use of such word for other purposes. Example: For buttons with icons I often use btn btn-secondary <icon-name>, If my icon is named close the button will get a lot of unwanted styles.
  2. Close icon’s use-case is generally a button, so why not btn btn-close?

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:8 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
MartijnCuppenscommented, Jan 21, 2020

What do you guys think about a more generic name, something we could apply for more buttons which have icons like the navbar toggler button?

0reactions
calvinkarpenkocommented, Sep 1, 2020

I think it would be worthwhile to make it in line with other “buttons”, for the sake of consistency. It would break things, but that’s the reason breaking changes are made on major versions. It’ll be changed in the documentation as well and anyboody updating to version 5 will, upon finding the close button not working, no dobut check the documentation and realise it has been changed, or will check a changelog.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Close button · Bootstrap v5.0
A generic close button for dismissing content like modals and alerts.
Read more >
How to set bootstrap alert close button? - Stack Overflow
Here's the problem, the close button is not showing like it should be on right side (not like button). Can anyone please help...
Read more >
Angular Close Bootstrap Modal - StackBlitz
Trigger the modal with a button -->. <button type="button" class="btn btn-info. btn-lg" data-toggle="modal". data-target="#myModal">Open</button>.
Read more >
Button | Webflow University
An overview of the button element. ... To reuse a style, click the class label and rename it in the Selector field of...
Read more >
Edit Icon | Font Awesome
Edit icon in the Version 5 Solid style. ... <i class="fas fa-edit"></i> ... We've cooked up some examples of how you could use...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found