question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rework modal dialogs

See original GitHub issue

Current modal implementation appears quirky in current browser/AT combinations, and has some known shortcomings:

  • while the modal uses focus trapping and aria-modal, this is still not supported correctly in all browser/ATs. for instance, Firefox/JAWS still allows navigating/reading through the underlying page; similarly, iOS VO ignores it, see https://github.com/twbs/bootstrap/issues/26770
  • when the dialog is opened and focus is moved, NVDA does not announce that we’re in a modal - see https://github.com/twbs/bootstrap/issues/33715
  • JAWS seems to have a weird issue with the initially set focus - once the modal is opened, the next tab and reading key press all go to the last button in the dialog, rather than starting at the top of the modal

We should take closer inspiration from https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html (but that misses the fix for iOS/VO, so would still not be sufficient to copy the approach from there). as mentioned previously (though can’t quite find where, worth also looking at approaches like https://github.com/KittyGiraudel/a11y-dialog, and possibly https://github.com/WICG/inert

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:3
  • Comments:12 (10 by maintainers)

github_iconTop GitHub Comments

3reactions
mkurzcommented, Mar 21, 2022
1reaction
RyanBerlinercommented, May 4, 2021

Sounds like there’s enough interest in improving these dialogs (modal & off canvas bootstrap components) - I should be able to push a PR this week so you all can start testing something tangible.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Modal - Bootstrap
Use Bootstrap's JavaScript modal plugin to add dialogs to your site for lightboxes, user notifications, or completely custom content.
Read more >
Design Patterns for Replacing Modal Windows
The problem with modal windows · Pattern 1: Show UI elements inline · Pattern 2: Collapsible UI Elements · Pattern 3: Dynamic Inline...
Read more >
Modal - Ant Design
Asynchronously close a modal dialog when the OK button is pressed. ... on 4.8.0 or above, you can pass a function to update...
Read more >
c# - Update modal dialog in Caliburn Micro from outside the ...
ShowDialog() opens a modal window, which is why it blocks the further operations in the main/parent window until the modal window is closed....
Read more >
Composing Reusable Modal Dialogs with Vue.js - Adam Wathan
Update Aug 12, 2017: All of the examples have now been updated for Vue 2.0! I was working on an app idea with...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found