Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[v4] Introduce variable for customizing margin-bottom for "p"

See original GitHub issue

_reboot.scss has:

p {
  margin-top: 0;
  margin-bottom: 1rem;
}

However the value is hardcoded. It would be nice to have it exported to _variables.scss so that people can customize (_custom.scss was nice but looks like it’s removed now).

Issue Analytics

State:
Created 6 years ago
Reactions:2
Comments:5 (2 by maintainers)

Top GitHub Comments

2reactions

k-funkcommented, Jul 17, 2017

I’d also like to see this change. Personally I like having the same margin for lots of block-level elements. p, figure, ul, ol, table, etc. I think that bootstrap3 based these margin-bottoms off of $line-height-computed (sometimes ($line-height-computed / 2)). Either way, it seems like a var is more flexible and clean than overriding css.

1reaction

BhaveshSGuptacommented, Jul 22, 2017

I would like to work on this for beta 2

Top Results From Across the Web

margin-bottom - CSS: Cascading Style Sheets - MDN Web Docs

The margin-bottom property is specified as the keyword auto , or a <length> , or a <percentage> . Its value can be positive,...

breadcrumb "margin-bottom" variable · Issue #23016 - GitHub

The "margin-bottom" property of the breadcrumb is fixed in "1rem" ... [v4] Introduce variable for customizing margin-bottom for "p" #23031.

Spacing - Bootstrap

Assign responsive-friendly margin or padding values to an element or a subset of its sides with shorthand classes. Includes support for individual properties, ......

Understanding CSS Variables - YoungInnovations' Blog

Here I've defined two CSS variables which have color values inside the :root selector. The variables are defined inside and are scoped with...

CSS Margin - W3Schools

The auto Value. You can set the margin property to auto to horizontally center the element within its container. The element will then...