Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
`*-half` icons should have consistent filled side
See original GitHub issueAll of the fill’ed versions of icons should be consistently filled on the left side.
Some filled Icons have the right side filled, where as the majority are left filled (ie. diamond, circle, triangle and square should be left filled)
Perhaps all *-half fill icons should be filled on the left, and maybe have an alt *-half-right version filled on the right?
Use-case example: ratings widget which shows #.5 rating. LTR would use the default half icon (*-half), while RTL could use the *-fill-right version). Typically users would want the star icons, but may use other icons for this purpose.
/cc @mdo
(context: working on a rating component that allows users to select their base icon, and noticed the inconsistent half side being filled)
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:5 (2 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Addressed in #249. I never actually exported the new half icons, sorry! And I’ve added book to the mix, too, since I had previously only done the shapes.
Have fixed this in Figma and will re-export for the the next alpha. Good call.