PSAR af0 used as af

Which version are you running? The lastest version is on Github. Pip is for major releases.

import pandas_ta as ta
print(ta.version)

0.3.14b0

Describe the bug I might have misunderstooded the idea but af0 = 0.01, af = 0.02 and I got ‘af0’ being used as ‘af’ and ‘af’ being ignored.

To Reproduce

    af0 = 0.01
    af = 0.02
    df_temp = df.ta.psar(high=df.high, low=df.low, close=df.close, af0=af0, af=af)

Expected behavior First ‘af0’ used after reversal as 0.01, and after new EP 'af’s new values should be 0.03 (af0 + 1xaf), 0.05 (af0 + 2xaf) and so on.

Screenshots

Thank you for your time!!!

[tiagomakoto]

Hello @tiagomakoto,

Hmmm… that doesn’t sound good! Thanks for bringing it to my attention.

Out of curiosity, does it also not work for the development branch?

$ pip install -U git+https://github.com/twopirllc/pandas-ta.git@development

In any case, psar is being re investigated for Issue #539 and PR #543 so I will add this to the list to double check.

Kind Regards, KJ

import pandas_ta as ta
print(ta.version)

0.3.67b0

And it still happens.

Also I just realized now that the code does take af0 as af since the column title with params is 0.01 (af) and 0.2 (max).

Best regards!

[twopirllc]

Hey @tiagomakoto and @AbyssAlora,

Thanks @tiagomakoto for verifying that it is also happening on the development branch.

Also, the only code that matters right now is on the development branch. Here is the psar for the development branch.

Furthermore, there is more than af0 that needs to be fixed, as I mentioned above, as well as create a numpy version to hopefully speed it up. Unfortunately, this won’t be fixed soon as I have a ton on my plate right now. But if you find a fix and make a Pull Request (PR), that definitely helps reduce my testing time.

KJ