Publish TypeDORM packages in ESM & CJS instead of UMD

Hello,

I am trying to use this nice library in some AWS lambda functions, but I am facing issues with bundling with both esbuild and webpack. Webpack is complaining with:

WARNING in ./node_modules/@typedorm/common/index.js 13:24-31
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

What is the reason of publishing this library as UMD?

[whimzyLive]

@mathieubrd This will get resolved soon and will be available in the Beta channel, latest by the end of the week next week.

Meanwhile, I would suggest skipping the TypeDORM packages from the bundle and installing it as external modules, when running in Lambda.

[aukevanleeuwen]

Thanks for your quick response, and the library in general.

We publish all the modules of this library in UMD so that they can be used in both Nodejs and Browser environments. (cjs and amd).

If I may be so blunt: isn’t that a bit of an old way of thinking about it? By publishing like this you’re essentially making your code un-bundle-able by commonly used bundlers such as esbuild, swc, rollup, .... Webpack does its very best but issues a gazillion Critical warnings such as Critical dependency: require function is used in a way in which dependencies cannot be statically extracted.

I would argue that:

1. Currently used browsers are more than capable of support ESM as an output format. https://caniuse.com/es6-module. Earliest implementations are from 2017: https://jakearchibald.com/2017/es-modules-in-browsers/ which is 5 years ago.
2. Nowadays people that are using these kind of libraries in their webapps are inclined to use bundlers such as the earlier mentioned ones. It’s the problem of the user of this library to make sure that the platform that he/she wants to use it in actually supports it. Basically the output target of those bundlers is what matters then right and you don’t have to worry about it.

Doesn’t it make more sense to make your library more bundle-able and tree-shake-able to help progress the web, while still allowing people that really need to support older browsers (but having the burden on them in that case)?