0.1.alpha-32 invalid syntax for integer. .findBy new functionality error with relations

.find* methods now have keyof for entity for fields, but passing relation entity fully gives db-level error. Passing id (as it worked in 0.0.11 version of typeorm) gives typescript compiler error that it’s supposed to be entity but not integer.

working:

0.0.11

await em.findOne(Post, {
  user: user.id,
  productName
});

but 0.1.alpha-32 same code does not compile, since find options are now keyof Entity

If I pass whole entity db dies with “invalid syntax integer” since it tries to use whole object in select.

Maybe I did not catch up with new functionality of some kind?

[pleerock]

no, not finding by relation. I told you to add a new column called userId, like this:

@Column({ nullable: true })
userId: number;

and relation will use this column (and create FK for this). It will work since their names match. Plus you can use it in findOptions

[idchlife]

@pleerock I actually thought it is designed and going to stay - column name as entity name without id postfixed and in database as key.

0.0.11 version

About your suggestion - this is interesting approach, but will 0.1 version support

await em.findOne(Post, {
  user: user,
  productName
})

?

Right now typeorm does not convert user entity object to it’s id so sql will be valid.

Wait a minute. I misread your post. You mean findBy is not actually supposed to work with relations, yes? Finding by relations.