Cascade deleting works incorrect

There is a small problem with cascade deleting.

I have an entity Chart with one to many relation:

@OneToMany(_type => ChartRow, row => row.chart, { cascadeAll: true })
public rows: ChartRow[]

The problem is when I try to remove this entity, I got constraint fails because the related entity are deleted after the main entity:

executing query: START TRANSACTION                                                                                                                                                         
executing query: DELETE FROM chart WHERE id=? -- PARAMETERS: [6]                                                                                                                           
executing query: DELETE FROM chart_row WHERE id=? -- PARAMETERS: [8]                                                                                                                       
executing query: DELETE FROM chart_row WHERE id=? -- PARAMETERS: [9]                                                                                                                       
executing query: DELETE FROM chart_row WHERE id=? -- PARAMETERS: [10]                                                                                                                      
query failed: DELETE FROM chart WHERE id=? -- PARAMETERS: [6]                                                                                                                              
error during executing query:Error: ER_ROW_IS_REFERENCED_2: Cannot delete or update a parent row: a foreign key constraint fails (`typeorm`.`chart_row`, CONSTRAINT `fk_79c9460c3e56c4b2119
675883d8` FOREIGN KEY (`chart`) REFERENCES `chart` (`id`))                                                                                                                                 
executing query: ROLLBACK                                        

So I tried to do cascade delete by database and added onDelete: "CASCADE":

@OneToMany(_type => ChartRow, row => row.chart, { cascadeAll: true, onDelete: "CASCADE" })

But the schema sync didn’t create the DDL alter table - it still have ON DELETE RESTRICT which don’t let me to delete this entity with the same error.

I can do the workaround and delete it manually:

await Promise.all(chart.rows.map(row => this.chartRowRepository.remove(row)));

But it’s not a point of using a relation db and ORM 😉

[pleerock]

I noticed one thing:

@OneToMany(_type => ChartRow, row => row.chart, { cascadeAll: true, onDelete: "CASCADE" })

onDelete: "CASCADE" should be set on inverse side, .e.g. on @ManyToOne side.

I havent tested this on master brach, but I did it my own branch and it works. My own branch contains changes for the next version of typeorm.

[MichalLytek]

I changed it to:

class ChartRow {
    @ManyToOne(_type => Chart, chart => chart.rows, { nullable: false , onDelete: "CASCADE"})
    public chart: Chart;
}

But the migration didn’t altered the fk and it’s still ONDELETE: Restrict. I’m using the 0.0.2-alpha.70 version so maybe your new persistence mechanism works better 😉