Column name aliasing broke in v 0.2.29

~~It looks like bug fix #6870 caused this regression. ~~ Edit from @imnotjames: It seems to be #4760

If you have a table with Primary key and another column with the same name, then the Primary ID name gets precedence. 0.2.28 was working correctly.

Issue Description

We have a table for example called Book which had a DB primary key in the db. But we don’t want to expose this to the users so we have created another column Book_id which has a UUID which we use in our API

@Entity({name: 'website_book'})
export class Book {
    @PrimaryGeneratedColumn({
        type: 'integer',
        name: 'id',     <========= 0.2.29 behavior 
    })
    oldBookId: number;

    @Column('int', {
        nullable: false,
        name: 'user_id',
    })
    user_id: number;

    @Column('character varying', {
        nullable: false,
        unique: true,
        length: 38,
        name: 'book_id',
    })
    id: string;    <========= 0.2.28 behavior 
}

Expected Behavior

" Book.id " should be mapped to (book_id column in the database)

Actual Behavior

" Book.id " is mapped to (id column in the database)

My Environment

Not os or env dependent issue

| TypeORM version : 0.2.29

Relevant Database Driver(s)

• aurora-data-api
• aurora-data-api-pg
• better-sqlite3
• cockroachdb
• cordova
• expo
• mongodb
• mysql
• nativescript
• oracle
• postgres
• react-native
• sap
• sqlite
• sqlite-abstract
• sqljs
• sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

I can help test the resolution

[ddehghan]

Great. It worked. 😃 Thanks a lot @imnotjames

[midoelhawy]

Hi everyone unfortunately, I have the same problem

TypeOrm use Class-model as table name in the final query

Code :

const banners = await AppDataSource.manager.find(Banner, {
                where: {
                    active: true
                }
            })

TYPE ORM QUERY RESULT :

SELECT 'Banner'.'id' AS 'Banner_id', 'Banner'.'image' AS 'Banner_image', 'Banner'.'description' AS 'Banner_description', 'Banner'.'type' AS 'Banner_type', 'Banner'.'price' AS 'Banner_price', 'Banner'.'link' AS 'Banner_link', 'Banner'.'active' AS 'Banner_active', 'Banner'.'customar_id' AS 'Banner_customar_id', 'Banner'.'updated_at' AS 'Banner_updated_at', 'Banner'.'created_at' AS 'Banner_created_at' FROM 'banners' 'Banner' WHERE ('Banner'.'active' = ?)'