Column not renamed when schema is set in Postgres

Issue Description

Automatic syncronization not detect column name or type was renamed or changed

Expected Behavior

Should detect change and syncronize with database

Actual Behavior

Typeorm not detecting column name / type was changed. But syncronize work if create new entity (typeorm creating new table)

Steps to Reproduce

Typeorm Config

{
  host: process.env.PG_HOST,
  port: process.env.PG_PORT,
  username: process.env.PG_USERNAME,
  password: process.env.PG_PASSWORD,
  database: process.env.PG_DATABASE,
  schema: process.env.PG_SCHEMA
  type: 'postgres',
  logging: ['error', 'migration', 'schema', 'query'],
  namingStrategy: new SnakeNamingStrategy(),
  synchronize: this.configService.isDevelopment(),
  logger: 'advanced-console',
  migrationsTransactionMode: 'each',
  entities: [
    __dirname + '/../**/*.entity.{ts,js}',
  ]
}

Entity

export enum CourierClass {
  SAMEDAY = 'same-day',
  NEXTDAY = 'next-day',
  REGULER = 'reguler',
}

@Entity()
export class Courier {
  @PrimaryColumn()
  code: string

  @Column()
  name: string

  @Column('enum', { enum: CourierClass })
  class: CourierClass

  @Column()
  cashless: boolean

  @Column()
  logistic: string
}

Edit: Minimal repository to reproduce https://github.com/ardyfeb/typeorm-syncronize-bug

• Run yarn run start it will syncronize first time
• Then try change some column, name -> name_changed
• Run yarn run start again to syncronize changes
• Updated column will not synced with database

My Environment

Dependency	Version
Operating System	Linux
Node.js version	v16.3.0
Typescript version	^0.2.34
TypeORM version	^4.3.5

Additional Context

Relevant Database Driver(s)

• aurora-data-api
• aurora-data-api-pg
• better-sqlite3
• cockroachdb
• cordova
• expo
• mongodb
• mysql
• nativescript
• oracle
• postgres
• react-native
• sap
• sqlite
• sqlite-abstract
• sqljs
• sqlserver

[imnotjames]

Digging more, this is a huge pain.

The way the table name is generated is incredibly inconsistent which is causing this issue. table.name gets set up as foo but then it gets compared against metadata.tablePath which is bar.foo. ):

I’m going to make a consistent path on the Table class which is always populated with the fully-qualified path name. This can be used for our internal comparisons. I think it will also fix a NUMBER of the other synchronization bugs we have. There’s also a few other places where I think this will help.

[imnotjames]

We reaaaaally need to create a test that would have caught this under the functional tests somewhere. I’ll get something up for that into a draft PR that I’ll use as a WIP.