Date column returns a date string instead of a date object

Issue type:

[ ] question [x] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [ ] mysql / mariadb [ ] oracle [x] postgres [ ] sqlite [ ] sqljs [ ] react-native

TypeORM version:

[ ] latest [ ] @next [x] 0.2.6 (or put your version here)

If I set a date column with @CreateDateColumn({type:'Date'}) in an entity. The result contains a date string {created: "2018-05-18"} instead of a date object.

I think it’s a bug because a date time column @CreateDateColumn() would return a date object.

@Entity()
export class Rate {
  @PrimaryGeneratedColumn()
  readonly id: number;

  @CreateDateColumn({type:'date'})
  created: Date;

}

[Gadzy]

This violates TypeScript type checking !

Let’s say we have a FooEntity and a FooService like this :

// foo.entity.ts
import {Entity, Column} from "typeorm";

@Entity()
export class FooEntity {

    @Column("date")
    someDate: Date;

}

// foo.service.ts
import { Connection, FindOneOptions, Repository } from 'typeorm'

import { FooEntity } from './foo.entity'

export class FooService {
  private readonly connection: Connection

  async fooMethod(options: FindOneOptions): Promise<FooEntity> {
    const { date } = await this.connection.getRepository(FooEntity).findOne(options)
    /*
      ...
    */
  }
}

The type of date is checked against Date at compile type and is instead string at runtime.

[pleerock]

Hi @qbodart, I don’t believe you 😃