Elements from this relationship are not deleted when an empty array is set

Issue type:

[x] question [ ] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [x] mysql / mariadb [ ] oracle [ ] postgres [ ] sqlite [ ] sqljs [ ] react-native

TypeORM version:

[x] latest [ ] @next [ ] 0.x.x (or put your version here)

class ProductsModel extends ORM {
    @OneToMany(type => ProductProductPropertiesModel, prodProdProperies => prodProdProperies.product, {
        eager: true,
        cascade: true,
        onDelete: 'CASCADE',
    })
    @JoinTable({
        name: 'product-product-properties',
        joinColumn: {
            name: "product_id",
            referencedColumnName: "id"
        },
        inverseJoinColumn: {
            name: "propuct_property_id",
            referencedColumnName: "id"
        }
    })
    productProductProperties: ProductProductPropertiesModel[];
}

export class ProductProductPropertiesModel extends ORM {
    @ManyToOne(type => ProductsModel, product => product.id, { nullable: false })
    @JoinColumn({ name: 'product_id' })
    product: ProductsModel;}

-------------------------

product.productProductProperties = [];
product.save();

-------------------------
Unhandled Promise rejection: ER_BAD_NULL_ERROR: Column 'product_id' cannot be null ; Zone: <root> ; Task: Promise.then ; Value: { QueryFailedError: ER_BAD_NULL_ERROR: Column 'product_id' cannot be null

How to automatically delete these records?

[i5o]

In case you reached here through Google, the solution that @nebkat provides does work.

[kelvin-evari]

Sorry I dig up this one but I’m having the same problem.

So you have an error:

Column ‘product_id’ cannot be null

try to figure out why it says so

This is because whenever updating an array, typeorm compares the new and old array to find which records should be remove. However, it set the value of foreign key to be null instead of removing those records: UPDATE "ProductProductPropertiesModel" SET "product_id" = $2 WHERE "id" = $1 -- PARAMETERS: [<id of should-be-deleted record>,null]. Since this column is set to nullable: false, this query causes the issue.

I have to remove those old records manually, which I don’t think is a good approach. Not sure why typeorm doesn’t remove them instead?