find operators like MoreThan and LessThan doesn't work properly for date fields

Issue type:

[ ] question [x] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [ ] mysql / mariadb [ ] oracle [ ] postgres [x] sqlite [ ] sqljs [ ] react-native

TypeORM version:

[x] latest [ ] @next [ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem: find operators like MoreThan and LessThan doesn’t work properly for date fields. some investigation showed that sqlite stores dates like 2018-06-05 15:57:27.249 but the query is like ... WHERE "User"."createdAt" > ? -- PARAMETERS: ["2018-06-05T01:01:32.650Z"] meaning it queries in ISO date format. when you just need comparison till day factor, it doesnt look like a problem but when you also need the time/hours/mins/etc then it doesnt return proper results. i only tested for sqlite so i dont know if same problem goes for other dbs.

[bioleyl]

@enif-lee Ok thanks. I usually use an other one: https://www.npmjs.com/package/date-fns You just don’t use the parameter date and you force new Date() in your function. Here is an update if someone is interested:

import { LessThan, MoreThan } from 'typeorm'
import { format } from 'date-fns'

// TypeORM Query Operators
export const MoreThanDate = (date: Date) => MoreThan(format(date, 'YYYY-MM-DD HH:MM:SS'))
export const LessThanDate = (date: Date) => LessThan(format(date, 'YYYY-MM-DD HH:MM:SS'))
// ...
const user = await repository.findOne({
    createdAt: MoreThanDate(new Date())
})

[ospfranco]

I was doing unit testing and found this problem, how is this still open for so long… very basic functionallity for an ORM.

I have a postgres db with timestamp fields in my entity, this is what I ended up using to make it work:

import { format } from 'date-fns';

export function ISOToDBDate(isoDate: string) {
  return format(new Date(isoDate), 'yyyy-MM-dd kk:mm:ss.SSS');
}