findOne for a ManyToOne relationship

Issue type:

[x] question [ ] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [ ] mysql / mariadb [ ] oracle [x] postgres [ ] cockroachdb [ ] sqlite [ ] sqljs [ ] react-native [ ] expo

TypeORM version:

[x] latest [ ] @next [ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

I am trying to findOne with a where in a related entity, but I can’t.

@Entity()
export class UserEntity extends BaseEntity {
  @PrimaryGeneratedColumn()
  id: number

  @Column({ length: 20 })
  username: string

  @OneToMany(() => GameMemberEntity, gameMember => gameMember.user)
  games: GameMemberEntity[]
}

@Entity()
export class GameEntity extends BaseEntity {
  @PrimaryGeneratedColumn()
  id: number

  @Column()
  name: string

  @Column({ default: false })
  published: boolean

  @OneToMany(() => GameMemberEntity, gameMember => gameMember.game)
  members: GameMemberEntity[]
}

@Entity()
export class GameMemberEntity extends BaseEntity {
  @ManyToOne(() => UserEntity, user => user.games, { primary: true })
  user: UserEntity

  @ManyToOne(() => GameEntity, game => game.members, { primary: true })
  game: GameEntity

  @Column({ default: false })
  edit: boolean
}

I’m trying use findOne, but members no pass to query parameters.

    const repository = await getRepository(GameEntity)
    const data = await repository.findOne({
      where: { id: 2, members: { user: { id: 5 } } },
      relations: ['members', 'members.user'],
    })

I expected that

...
WHERE "game_entity"."id" = 2 AND "game_member_entity"."userId" = 5;

But is

...
WHERE "game_entity"."id" = 2;

[miyi]

if you are looking for a GameEntity with id: 2, you already found the object you are looking for, the additional GameEntityMember: { user: id } requirement is redundant.

const repository = await getRepository(GameEntity)
    const data = await repository.findOne({
      where: { id: 2},
      relations: ['members', 'members.user'],
    })

will give you the exact same result as below every time

const repository = await getRepository(GameEntity)
    const data = await repository.findOne({
      where: { id: 2, members: { user: { id: 5 } } },
      relations: ['members', 'members.user'],
    })

[maximelafarie]

Just a question, are you using @nestjsx/crud? Because I think (in my case) it can come from it…

Anyway, I fixed this with:

  async findByToken(token: string): Promise<Users | undefined> {
    return this.repo.createQueryBuilder('user')
    .leftJoinAndSelect(
      'user.userProduits',
      'userProduits')
    .where('userProduits.token = :token', { token })
    .getOne();
  }

I hope it will help you! 🖖