findOneOrFail throws when selecting a null valued column

Issue type:

[ ] question [x] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [ ] mysql / mariadb [ ] oracle [x] postgres [ ] sqlite [ ] sqljs [ ] react-native

TypeORM version:

[ ] latest [ ] @next [x] 0.2.3 (or put your version here)

findOneOrFail() throws when it shoulddn’t.

Given this entity:

@Entity()
class Company {
    @PrimaryGeneratedColumn()
    id: number

    @Column()
    name: string

    @Column({nullable:true})
    nullName: string
}

then this snippet shows the problem:

// Given
const company = new Company()
company.name = "Company A"
await companyRepo.save(company)

// Then - This works
const c1 = await companyRepo.findOneOrFail(company.id, {select: ["name"]})
// Then - This throws "EntityNotFound: Could not find any entity of type "Company" matching: 1"
const c2 = await companyRepo.findOneOrFail(company.id, {select: ["nullName"]})

[wiktor-obrebski]

it’s very confusing and can easily lead to errors that can be missed before production release. if typeorm need id, it should always fetch id, even if it is not asked for it.

[akwodkiewicz]

What is the reason for ~the bug to occur~ this behaviour? Is the entity id column always required, or is selecting a single nullable column parsed in a wrong way, when the value is null?