Get relation with trashed

Feature Description

Get relation with trashed entities

The Problem

class User {
    @PrimaryGeneratedColumn({ type: 'bigint', unsigned: true })
    readonly id: string;

   @DeleteDateColumn()
    deleted_at: Date;

   @OneToMany(() => Review, (review: Review) => review.user)
    reviews: Promise<Review[]>;
}


class Review {
    @PrimaryGeneratedColumn({ type: 'bigint', unsigned: true })
    readonly id: string;

    @Index()
    @ManyToOne(() => User, (user: User) => user.reviews, { onDelete: 'CASCADE', nullable: false })
    @JoinColumn({ name: 'user_id', referencedColumnName: 'id' })
    user: Promise<User>;
}

When User is deleted than await review.user gives null. So when I need with trashed, I must use getRepository(User).createQueryBuilder()…etc.

The Solution

class Review {
    @PrimaryGeneratedColumn({ type: 'bigint', unsigned: true })
    readonly id: string;

    @Index()
    @ManyToOne(() => User, (user: User) => user.reviews, { onDelete: 'CASCADE', nullable: false, withDeleted: true })
    @JoinColumn({ name: 'user_id', referencedColumnName: 'id' })
    user: Promise<User>;
}

See withDeleted: true in ManyToOne

Relevant Database Driver(s)

• aurora-data-api
• aurora-data-api-pg
• better-sqlite3
• cockroachdb
• cordova
• expo
• mongodb
• mysql
• nativescript
• oracle
• postgres
• react-native
• sap
• sqlite
• sqlite-abstract
• sqljs
• sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

• Yes, I have the time, and I know how to start.
• Yes, I have the time, but I don’t know how to start. I would need guidance.
• No, I don’t have the time, although I believe I could do it if I had the time…
• No, I don’t have the time and I wouldn’t even know how to start.

[hastom]

@pleerock your solution does not look like it will query deleted photos. It will find user with specified id if it has non-deleted photos. But it got me thinking about an object notation for relations. What about:

usersRepository.find(id, {
  relations: {
    photos: { where: { id: 12 }, withDeleted: true } // and other find options for precise control of what will be loaded
  }
})

Maybe not full support of all find options but basics can be supported and even type-hinted

[hastom]

+1 Also it would be very nice to have an option to specify which trashed entities to include on per-query basis. Something like

usersRepository.find(id, { relations: ['photos', 'photos.comments:withDeleted'] })

or

usersRepository.find(id, { relations: ['photos'], relationsWithDeleted: ['photos.comments'] })