getCount() not DISTINCT()?

Issue type:

[ ] question [ ] bug report [x ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [x ] mssql [ ] mysql / mariadb [ ] oracle [ ] postgres [ ] cockroachdb [ ] sqlite [ ] sqljs [ ] react-native [ ] expo

TypeORM version:

[ x] latest [ ] @next [ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

now getCount() => select count(DISTINCT(id)), i want select count(id)orselect count(*)

.getCount({ DISTINCT: false })

[evan-lin9]

Id is primary key. My problem is when the amount of data is too large, the query speed is not as good

[Leulz]

@imnotjames I was thinking of creating a new issue here for a Feature Request, since I’d like the repository.count() to have the possibility to be not distinct. But then I found this issue and read your comments, and now I’m not so sure.

This feature is wanted by me due to the fact that in Postgres, a COUNT(DISTINCT...)) query can be pretty heavy. There are quite a few references online talking about that, this article being one example. So, for Postgres, it’d be great if we could tell typeorm that we know that the distinct is not needed. The default behaviour would keep being the current one, of course.

Do you think this feature would be useful? I’m currently getting around it by using a QueryBuilder, but it’d be far less verbose if I could just pass an option to count.