inheritance - change primary key options

Issue type:

[ ] question [x] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [x] mysql / mariadb [ ] oracle [ ] postgres [ ] cockroachdb [ ] sqlite [ ] sqljs [ ] react-native [ ] expo

TypeORM version:

[x] latest [ ] @next [ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

class Base {
  @PrimaryGeneratedColumn()
  id:number;
}

@Entity()
class Demo extends Base {
  @PrimaryColumn({
    generated:false
  })
  id:number;
}

It created a table demo with primary key id auto incremented. generated:false is not working.

[Diluka]

@vlapo No, it’s not the same.

My propose

1. I’m not inheriting table. the Base class is not going to sharing tables. It is the template to use in every tables.
2. this is class inheritance. overriding property is legal.
3. I don’t want to change type. Even if I change the type(still number, but maybe integer or float) it is still reasonable. (repeat it is not table inheritance. there is no @TableInheritance)
4. I want to modify non-type options. in this demo, I’m just disabling the primary key auto generation.

Real scenario

I have multiple tables all with a primary id using the same type int. Most of those are auto increment. But there is one table using one-to-one relation with shared primary/foreign keys. So the child table’s (which has foreign key) primary key must be mandatory set the same value from the main table. So the generated need set to false.

[vlapo]

I know it is not a same. I just want link this issue with #2865, in case someone will implement enhancement of inheritance (basically both problems are with inheritance and primary columns).

I understand your problem but it is not implemented. It is not possible define superclass with primary generated column, extends and disable auto generation in in subclass 😃