Multiple update queryBuilder, success in PgAdmin4 but not in typeorm

Issue Description

Same query, work in PgAdmin4 but not in typeorm

Expected Behavior

They should provide same result, or any other method that can do multiple updates are welcome

Actual Behavior

Same query but different result, error occur in typeorm but not in PgAdmin4

Steps to Reproduce

This is my entity

@Entity()
export class EthTransaction extends BaseEntity {
  @PrimaryGeneratedColumn()
  id: number;

  @Column({unique:true})
  txid: string;

  @Column()
  blockHeight: number;

  @Column()
  coin: string;

  @Column()
  fromAddress: string;

  @Column()
  toAddress: string;

  @Column()
  value: string;

  @Column({default:"new"})
  webhookStatus:string;

  @CreateDateColumn()
  createAt: Date;

  @UpdateDateColumn()
  updateAt: Date;
}

This is actually db

I try to do multiple records update with single query, which update webhookStatus by an array of txid I first try with typeorm

const queryBuilder = await getConnection()
.createQueryBuilder()
.update(EthTransaction)
.set({ webhookStatus: status })
.where("txid IN (:txids)", {txids:txids})
.execute()

It give me a query like this

queryBuilder [
  'UPDATE "eth_transaction" SET "webhookStatus" = $1, "updateAt" = CURRENT_TIMESTAMP WHERE "txid" IN ($2)',
  [
    'pending',
    [
      '0x8bef57e3ee1b35e4a02286fc4a21ddd8392f8e215685e275b9b65f4aac6a2219',
      '0x1074e795c79d7f2ffb749252421a61f69bab14cc80eed43e45ca89ac7c684a49'
    ]
  ]
]

And error comes

error QueryFailedError: could not determine data type of parameter $1
    at new QueryFailedError (/home/project/node_modules/typeorm/error/QueryFailedError.js:11:28)
    at PostgresQueryRunner.<anonymous> (/home/project/node_modules/typeorm/driver/postgres/PostgresQueryRunner.js:247:31)
    at step (/home/project/node_modules/typeorm/node_modules/tslib/tslib.js:141:27)
    at Object.throw (/home/project/node_modules/typeorm/node_modules/tslib/tslib.js:122:57)
    at rejected (/home/project/node_modules/typeorm/node_modules/tslib/tslib.js:113:69)
    at processTicksAndRejections (internal/process/task_queues.js:97:5) {
  length: 111,
  severity: 'ERROR',
  code: '42P18',
  detail: undefined,
  hint: undefined,
  position: undefined,
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: undefined,
  table: undefined,
  column: undefined,
  dataType: undefined,
  constraint: undefined,
  file: 'postgres.c',
  line: '1469',
  routine: 'exec_parse_message',
  query: 'UPDATE "eth_transaction" SET "webhookStatus" = $2, "updateAt" = CURRENT_TIMESTAMP WHERE "txid" IN ($2)',
  parameters: [
    'pending',
    [
      '0x8bef57e3ee1b35e4a02286fc4a21ddd8392f8e215685e275b9b65f4aac6a2219',
      '0x1074e795c79d7f2ffb749252421a61f69bab14cc80eed43e45ca89ac7c684a49'
    ]
  ]
}

But when i do the same query in PgAdmin 4, it pass and did the job

UPDATE "eth_transaction" SET "webhookStatus" = 'pending', "updateAt" = CURRENT_TIMESTAMP WHERE "txid" IN ('0x8bef57e3ee1b35e4a02286fc4a21ddd8392f8e215685e275b9b65f4aac6a2219', '0x1074e795c79d7f2ffb749252421a61f69bab14cc80eed43e45ca89ac7c684a49');

My Environment

Ubuntu 20.04
nodejs v12.19.0
typescript
nestjs 7.5.1
@nestjs/typeorm": "^7.1.5
typeorm": "^0.2.30
typescript": "^4.0.5
@typescript-eslint/eslint-plugin": "^4.6.1
@typescript-eslint/parser": "^4.6.1

Additional Context

Relevant Database Driver(s)

• aurora-data-api
• aurora-data-api-pg
• better-sqlite3
• cockroachdb
• cordova
• expo
• mongodb
• mysql
• nativescript
• oracle
• postgres
• react-native
• sap
• sqlite
• sqlite-abstract
• sqljs
• sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

• Yes, I have the time, and I know how to start.
• Yes, I have the time, but I don’t know how to start. I would need guidance.
• No, I don’t have the time, although I believe I could do it if I had the time…
• No, I don’t have the time and I wouldn’t even know how to start.

[asomethings]

const queryBuilder = await getConnection()
  .createQueryBuilder()
  .update(EthTransaction)
  .set({ webhookStatus: status })
  .where("txid IN (:...txids)", {txids:txids})
  .execute()

You are trying to send array as an “array”. You have to make it unpack through typeorm. Above example should work as expected.

[jackykwandesign]

@jackykwandesign It’s actually in the doc although it’s select but still it’s an query builder so I think people will think it’s compatible

Thanks for your reminder