question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Not stable CI tests for @next version of TypeORM

See original GitHub issue

Issue type:

  • bug report

TypeORM version:

  • @next

Not stable CI tests

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
Kononnablecommented, Jun 22, 2019

Skipping failing test is a bad idea(in general). We would forget about them in the future and they wouldn’t be tested(or fixed) at all. In local development I sometimes skip broken tests and enable just before pushing the branch(or skip entire db driver if most of tests are failing).

As for 0.3.0 - it’s a tricky subject. It is alive for a year now but there are still some changes there to be made and for some of them we have not agreed on implementation(yet). So if you’ve got a time and doesn’t have to implement a specific feature it might be better to avoid it. It is mostly completed by there is a chance you would spend a day of two on understanding the code which would be changed a day later.

When fixing bugs in 0.2 you could check if they’re not working on 0.3(if it’s just a matter of quick look) and prioritize those not running in both versions. I would advice you to start in one area(issue label) and pick bugs from there. It’s much easier to fix a bug when you’re already familiar with code of that fragment of typeorm. If you’d like you can also review PRs. It can save a lot of time if someone a bit familiar with our codebase and contributing guidelines reviews PRs before @pleerock checks if it can be merged. Often only tiny problems are blocking PRs, but they have to wait 2-3 more weeks because @pleerock doesn’t have enough time to check them on a daily basis(so if he is the only one reviewing them this process may take some time).

1reaction
vlapocommented, Jun 21, 2019

@YegorZaremba I think the best is fix bugs for now. Check issues here and pick one 😉

Read more comments on GitHub >

github_iconTop Results From Across the Web

Guide / Sample for Testing with Jest · Issue #5308 · typeorm ...
This guide would ideally have patterns for both using real connections for integration testing as well as mocking the TypeORM connection / ...
Read more >
End-to-end testing in NestJS with TypeORM - LogRocket Blog
Create end-to-end tests in NestJS and use TypeORM to provide database connectivity in our application.
Read more >
TypeORM - Quick Guide - Tutorialspoint
It shows the version. If it is not installed, download the latest version and install on your machine. Install TypeORM. Let us install...
Read more >
Getting started with continuous integration for Nest.js APIs
Learn how to build RESTful APIs with Nest.js, a Node.js framework built with TypeScript, and automate testing using CircleCI.
Read more >
typeorm - npm
TypeORM is an ORM that can run in NodeJS, Browser, Cordova, PhoneGap, Ionic, React Native, NativeScript, Expo, and Electron platforms and ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found