Problems working with repository.count

Issue type:

[x] question [x] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [x] mongodb [ ] mssql [ ] mysql / mariadb [ ] oracle [ ] postgres [ ] cockroachdb [ ] sqlite [ ] sqljs [ ] react-native [ ] expo

TypeORM version:

[x] latest [ ] @next [ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

@Entity()
export abstract class EntityAbstract {
    @ObjectIdColumn()
    _id: ObjectID;

	@Column()
	name: string;

    @CreateDateColumn({type: 'timestamp', update: true})
    createdAt: Date;

    @UpdateDateColumn({type: 'timestamp'})
    updatedAt: Date;

    @Column({type: 'timestamp'})
    deletedAt: Date;
}

console.log(await this.repository.find({where: {deletedAt: {$exists: true}}})); // ok, return 2 record
console.log(await this.repository.count({where: {deletedAt: {$exists: true}}})); // opps, return 0

[danmana]

I ran also into this issue when Using Repository.

The problem is the typings.

The more generic Repository class has three signatures for count:

count(options?: FindManyOptions<Entity>): Promise<number>;
count(conditions?: FindConditions<Entity>): Promise<number>;
count(optionsOrConditions?: FindManyOptions<Entity>|FindConditions<Entity>): Promise<number>;

But MongoRepository implementation only has

count(query?: ObjectLiteral, options?: MongoCountPreferences): Promise<number>;

This is equivalent to the second signature, the one with FindConditions

So in case you are using Mongo you can only use the second signature from Repository

// good signature
repository.count({ myField: "myValue"});

// bad signature, even if the typing says it's valid !
repository.count({ where: { myField: "myValue"}});

You have two options:

• you take care and always use just the second signature
• or you switch the type of your repository to MongoRepository and get the correct typings

[playahater]

Perhaps not a best way to address the issue, but let me do it here for start and we can move it in a separate issue if needed.

Issue type:

[ ] question [x] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [x] mysql / mariadb [ ] oracle [ ] postgres [ ] cockroachdb [ ] sqlite [ ] sqljs [ ] react-native [ ] expo

TypeORM version:

[ ] latest [ ] @next [x] 0.2.18 (or put your version here)

Steps to reproduce or a small repository showing the problem:

I can reproduce the same issue with mysql driver. Seem like that repository.count is not returning correct count results in my case as well.

have a simple condition in it: repository.count({ ColumnA: valueA, ColumnB: ValueB });