Query builder regression in 0.2

Issue type:

[ ] question [X] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [ ] mysql / mariadb [ ] oracle [X] postgres [ ] sqlite [ ] sqljs [ ] react-native

TypeORM version:

[X] latest [ ] @next [X] 0.1.20 (or put your version here)

Steps to reproduce or a small repository showing the problem:

Query builder generated SQL changed after upgrade to 0.2 in a way that affects results. This

connection
  .getRepository(Model)
  .createQueryBuilder('model')
  .select('id')
  .whereInIds([ 1, 2 ])
  .andWhere('column = 1')
  .getMany());

produces

WHERE ("model"."id" = $1) OR ("model"."id" = $2) AND column = 1 -- PARAMETERS: [1,2]

in 0.2.5, and

WHERE ("model"."id"=$1 OR "model"."id"=$2) AND column = 1 -- PARAMETERS: [1,2]

in 0.1.20. Because of the parentheses over id conditions have changed, a different set of results is returned. If the order of the conditions is changed to

connection
  .getRepository(Model)
  .createQueryBuilder('model')
  .select('id')
  .where('column = 1')
  .andWhereInIds([ 1, 2 ])
  .getMany());

the generated SQL is

WHERE column = 1 AND (("model"."id" = $1) OR ("model"."id" = $2)) -- PARAMETERS: [1,2]

for 0.2.5 and

WHERE column = 1 AND ("model"."id"=$1 OR "model"."id"=$2) -- PARAMETERS: [1,2]

for 0.1.20, and both thus return the same results.

[silentroach]

yep, I know how to fix it and will try to do this in few days 😃

[pleerock]

okay, so if it does following query:

select * from items where (id = 3) or (id = 2) and x = 1;

then we shall make a fix to make it this way:

select * from items where ((id = 3) or (id = 2)) and x = 1;