[Question] Pb with custom repository in class-validator custom

Hi !

Little problème when i add Custom validator to an Entity :

@ValidatorConstraint({ async: true })
export class IsProductNotExistConstraint implements ValidatorConstraintInterface {

  public validate = async (productName: any, _args: ValidationArguments): Promise<boolean> => {
    const product: Product | undefined = await RepositoryFactory.getRepository(ProductRepository).findOneByName(productName);
    if (product === undefined) {
      return false;
    } else {
      return true;
    }
  }

}

export function IsProductNotExist(validationOptions?: ValidationOptions): ((object: Object, propertyName: string) => void) {
  return (object: Object, propertyName: string): void => {
    registerDecorator({
      target: object.constructor,
      propertyName: propertyName,
      options: validationOptions,
      constraints: [],
      validator: IsProductNotExistConstraint
    });
  };
}

The factory use connection.getCustomRepository function. But if i do this, routing-controller return this response :

{ "name": "CustomRepositoryCannotInheritRepositoryError", "message": "Custom entity repository ProductRepository cannot inherit Repository class without entity being set in the @EntityRepository decorator." }

Alright, my repository use EntityRepository decorator :

@EntityRepository(Product)
export class ProductRepository extends Repository<Product> {

  public findOneByName = async (name: string): Promise<Product | undefined> => {
    return this.findOne({name: name});
  }

}

Have an idea to fix this ? Thanks ! And great job !

[pleerock]

Try to add console.log before entityrepository decorator:

console.log("Product", Product);
@EntityRepository(Product)

And you’ll see Product undefined in console.

How this can be possible? It executes Product entity code after it executes this code because someone else is executing something else that has dependency in product and somewhere else, hard to say, you have a bad files organization and circular references which cannot be resolved by language. I suggest you to start from scratch and organize a better project structure.

This issue not related to typeorm somehow so Im closing it.

[StephenBeg]

Hi,

Thanks for answer. I see the circular reference : Entity -> Validator -> Custom Repository -> Entity -> …

I thinks this pb is unsolvabled and your example in class-validator project doesn’t work to :

import {registerDecorator, ValidationOptions, ValidatorConstraint, ValidatorConstraintInterface, ValidationArguments} from "class-validator";

@ValidatorConstraint({ async: true })
export class IsUserAlreadyExistConstraint implements ValidatorConstraintInterface {

    validate(userName: any, args: ValidationArguments) {
        return UserRepository.findOneByName(userName).then(user => {
            if (user) return false;
            return true;
        });
    }

}

export function IsUserAlreadyExist(validationOptions?: ValidationOptions) {
   return function (object: Object, propertyName: string) {
        registerDecorator({
            target: object.constructor,
            propertyName: propertyName,
            options: validationOptions,
            constraints: [],
            validator: IsUserAlreadyExistConstraint
        });
   };
}

(UserRepository) create a circular reference.