Repository Remove method deletes the Entity Id

Issue Description

I have a simple delete function

async delete(id: number) {
    const entity = await this.findOne(id);
    console.log(`Entity Before: `, entity);
    const res = await this.repo.remove(entity);
    console.log(`Delete Result: `, res);
    console.log(`Entity After: `, entity);
    return res;
  }

After remove the i do not get the id in the response and it is also removed from the entity as well

Expected Behavior

Id should not be removed

Actual Behavior

My Environment

Using in NestJs

| Operating System | ElementryOs | | Node.js version | v12.18.4 |

| TypeORM version | 0.2.29 |

Relevant Database Driver(s)

• postgres

[br0wn]

@nebkat @all2pie I also stumbled upon this issue, as I like to return the removed/deleted entity(s) as a result of “delete” action…

Here is the code that is handling this case: https://github.com/typeorm/typeorm/blob/70938017ff17dc21e4a98512479b3645a78665e5/src/persistence/SubjectExecutor.ts#L681

I would like to understand what was the reason for implementing it like this.

[nebkat]

Well spotted @br0wn, this was added in aa5670a04554cfcbf6f89ccb21016ec4948bc65f, not much info there.

I presume the logic was to ensure that the entities would no longer be used elsewhere or conflict with newly inserted items? If the items are to be re-added it should be with new IDs probably.