Save + null prototype object = Cannot convert object to primitive value

Issue type:

[x] bug report

Database system/driver:

[x] postgres (but likely not db specific)

TypeORM version:

[x] latest

Steps to reproduce or a small repository showing the problem:

Error + stack:

error: GraphQL failure: TypeError: Cannot convert object to primitive value
    at Array.join (<anonymous>)
    at Array.toString (<anonymous>)
    at isNaN (<anonymous>)
    at Function.Object.<anonymous>.OrmUtils.compare2Objects (/Users/markcrawshaw/Code/metamap-server/src/util/OrmUtils.ts:171:13)
    at Function.Object.<anonymous>.OrmUtils.deepCompare (/Users/markcrawshaw/Code/metamap-server/src/util/OrmUtils.ts:118:23)
    at /Users/markcrawshaw/Code/metamap-server/src/persistence/SubjectChangedColumnsComputer.ts:90:38

Error reported when null prototype object is passed. It is due to global isNaN not being safe with null prototype objects. It can be fixed by either correcting the order of the if conditions or by using Number.isNaN.

util/OrmUtils.ts@compare2Objects from

if (isNaN(x) && isNaN(y) && typeof x === "number" && typeof y === "number")

to

if (typeof x === "number" && typeof y === "number" && isNaN(x) && isNaN(y))

And if you’re wondering if global isNaN could really do this, try this:

let result;

const nullProtoObject = Object.create(null);
nullProtoObject.prop = "value";

try {
  isNaN(nullProtoObject);
}
catch (e) {
  result = `isNaN NOT SAFE (${e})`;
}

console.info(result || "isNaN SAFE")

Regards, Mark.

[pleerock]

I’m going to publish a new release this Friday. Thanks!

[mcrawshaw]

No worries @pleerock, thanks @zbessette! This will fix the issue.

Closing as available in next release.