Search by objectId doesn't work for MongoDB

Issue type:

[ ] question [ x] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ x] mongodb [ ] mssql [ ] mysql / mariadb [ ] oracle [ ] postgres [ ] cockroachdb [ ] sqlite [ ] sqljs [ ] react-native [ ] expo

TypeORM version:

[x ] latest [ ] @next [ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

import { ObjectID } from "mongodb";
import { Column, Entity, Index, ObjectIdColumn } from "typeorm";

@Entity()
@Index(["clientId", "name"], { unique: true })
export class User {
  @ObjectIdColumn()
  public id: ObjectID;

  @Column()
  public companyRef: ObjectID;

  @Column()
  public name: string;

  @Column()
  public mobile: number;
}

const repository = getMongoRepository(EventSchema);
const id = "hex-string";
// These work
repository.findOne(id);
repository.find({where:{ _id: id }});

// But this doesn't
repository.find({id: id, mobile: [phone]});

[belukha]

It doesn’t work, because _id is NOT instance of ObjectID. To make it work, you should manually create ObjectID instance, something like this

//Note, that I use constructor from mongodb and type from typeorm, but they shouldn't have the different names if they're in different files
import { ObjectID } from 'mongodb';
import { ObjectID as ObjectIDType} from 'typeorm'

@Entity()
export class User {
  @ObjectIdColumn()
  _id: ObjectIDType;

  @Column()
  name: string;
}

const userId = '5d961d865ede2a35d0f51207';

const userRepository = connection.getMongoRepository(User);
const user = await userRepository.findOne({
 _id: new ObjectID(userId)
});

//or just use
const user = await userRepository.findOne(userId)

[viktorstaikov]

Hey guys,

I was just reading the issue here and experimenting with some stuff and randomly I’ve nailed it:

async findById(id: string): Promise<UserEntity> {
   return await this.userRepository.findOne(id);
}

Basically one have to pass only the id to basically find by id in mongo. This is my entity class:

@Entity('users')
export class UserEntity {
  @ObjectIdColumn()
  id: string;

  @Column({ unique: true })
  email: string;

  @Column()
  password: string;
}

It is definitely not a fix, more like a workaround.