SoftDelete in relationships cascade does not work

Issue type:

[ ] question [x] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [x] mysql / mariadb [ ] oracle [ ] postgres [ ] cockroachdb [ ] sqlite [ ] sqljs [ ] react-native [ ] expo

TypeORM version:

[ ] latest [ ] @next [ ] 0.2.24 (or put your version here)

In one to many relationship the sofdelete does not update the related entity:

The Gestion entity has a one-to-many relationship with the Incedence entity

Gestion entity

....

@DeleteDateColumn({ type: "datetime" })
deletedAt: Date;

....

 @OneToMany(type => Incidence, incidence => incidence.gestion,{ 
    cascade: true 
  })
  incidences: Incidence[];

Inverse relationship

Incidence entity

...

@DeleteDateColumn({ type: "datetime" })
  deletedAt: Date;

...

@ManyToOne(type => Gestion, gestion => gestion.incidences)
  gestion: Gestion;

 await gestRepository.softDelete({id:gestionId})

The deleteAt column of the Gestion entity is set correctly with the date but the related entity Incidence is not affected, it remains null

[mikehroth]

Immediately after posting I discovered that if I include the relations in my original query then the cascade deletes will work.

For example, the following did not soft delete the children:

const parent = await repo.findOneOrFail({ id })               
await repo.softRemove(parent)         

Then by adding the relations it did:

const parent = await repo.findOneOrFail({ id }, {
    relations: ['children']
}) 
repo.softRemove(parent)

My entities are as follows:

// Parent
  @OneToMany(
    (type) => Child, 
    (joint) => child.parent,
    { cascade: true }
  )
  public children: Child[];

// Child
  @ManyToOne(
    (type) => Parent, 
    (parent) => parent.children
  )
  public parent!: Parent;

---

Also to note, the only way to get the cascade to work properly is to use softRemove and pass the entire entity in with all children. e.g. repo.softRemove(parent) where parent contains all children. I suppose this makes sense, otherwise the softRemove method would have to perform additional queries for all children and nested children, but the behavior isn’t very intuitive or helpful seeing as one could simply query the children separately and pass them to repo.softRemove().

[xavierdemoor]

Ok, in your example it works if I change something on parent. In this case, I don’t want to change anything except deletedAt which is done by softRemove().

It’s a part of a feature that receive an event when a guild leave, find if settings for this guild exist, if yes softRemove it and softremove all guild’s members settings too.

Because softRemove() change something on the parent (the deletedAt column), I was thinking this will propagate the fact that parent is softRemoved and childrens need to be softRemoved too.