TypeError: Issues in constructor

Issue type:

[ ] question [x ] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [ ] mysql / mariadb [ ] oracle [x ] postgres [ ] sqlite [ ] sqljs [ ] websql

TypeORM version:

[x ] latest [ ] @next [ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

1. Clone this repo https://github.com/cedrickmandocdoc/typeorm-bug
2. Create PG Database with name test, edit what roles you will used
3. Install packages
4. Compile run tsc
5. Run index.js Result:
6. You will notice that there is a TypeError.

I guess this is because of the constructor. I believe there is workaround here, but I want to preserve also the types and have strictnullchecks set to true. Though if I edit the constructor parameters and isolate it one by one. It will works. I just want to know why this sample repo didn’t work. I guess this is a bug.

[pleerock]

You have two issues. create does not save entity in the database and it does not return you a promise, and it does not accepts constructor arguments, you are using it completely wrong (I guess you are confusing methods of sequelize library, create in typeorm serves different purpose). Your correct code for saving entity is:

  await userRepository.save(new User({
    firstName: 'test',
    lastName: 'test',
    age: 1
  }));

Second, your entity constructor arguments must be optional, its a requirement, since when loading entities from the database ORM creates instances of the classes, and it does not aware of your constructor arguments and what it shall provide there. How it should be in your code:

  public constructor(data?: User) {
    if (data) {
      this.firstName = data.firstName;
      this.lastName = data.lastName;
      this.age = data.age;
    }
  }

[nitzantomer]

That’s exactly what this feature is created for, so I think it’s using it wisely. There are no “hacks” here, in fact, your solution is the hack as it actually translates into the javascript output. My solution keeps the js code clean and simple.