feat: validateOrReject should throw instance of Error

validateOrReject throws an array of errors that does not have a stack. That is bad in case such error is not being caught and results in 500 Internal Server Error.

Is it possible to add something like validateOrError that would throw an instance like this instead:

class ObjectInvalid extends Error {
  errors: ValidationError[]
}

[vlapo]

Sure why not. Let’s introduce new validateOrThrow method and mark validateOrReject as deprecated.

[bogdan]

Not all of the rejects are being caught and processed. It means that if the error is displayed in console or sent to exception notification software, you will have no error stack available.

Example jest error when validateOrReject throws:

      161 |     });
      162 |
    > 163 |     it('fails', async () => {
          |     ^
      164 |       await validateOrReject(new Reseller())
      165 |     });
      166 |   });

You may see that jest can only tell the test where the error occurred not the line number and backtrace.

When you see something like this in console:

Failed: Array [
      ValidationError {
       ...
      },
    ]

You have no idea where to fix it.

Any linter will tell you that throwing something that doesn’t inherit Error class is a bad idea:

https://palantir.github.io/tslint/rules/no-string-throw/ https://eslint.org/docs/rules/no-throw-literal

BTW, this is first time I see someone throws an Array. IMO it is even more terrible idea than throwing a string because when you see it in console you don’t even realize what had happened.