fix: `@IsNotEmpty` not working on non-existent field

Description

I would expect @IsNotEmpty to fail if the attribute is not included. For example, I have the following DTO

export class ServiceDto {
  @ApiProperty({ description: 'The type unique id of the service' })
  readonly id: number;
    
  @IsNotEmpty()
  @ApiProperty({ description: 'The type of service' })
  readonly type: string
}

export class CreateServiceDto extends PartialType(
  OmitType(ServiceDto, ['id'] as const),
) {}

When I pass the following object:

{ id: 1, type: "" }

validation works saying the field may not be empty however, when I pass the following object it will not complain:

{ id: 1 }

After reading the documentation I found that there is an @IsOptional decorator, so I would assume all other fields are mandatory by default if not set. After some experiments, this behavior is true for other decorators such as @IsNumber.

Reproduction

I tried it via the main app and the e2e app and I get the same behavior. I simply used it in the main.ts of my NestJS app

  const app = await NestFactory.create(AppModule);
  app.useGlobalPipes(new ValidationPipe());
  await app.listen(3000)

where my DTO is called by my controller with the following code

  @ApiTags('Service')
  @ApiOperation({summary: "This will create a new service record"})
  @Post()
  @ApiCreatedResponse({ description: "Record created" , type: ServiceDto})
  create(@Body() createServiceDto: CreateServiceDto) {
    return this.serviceRepository.createService(createServiceDto)
  }

class-validator version: 0.12.2

[braaar]

This is a weird way to extend classes I don’t even understand what PartialType and OmitType is in this example.

In case you’re curious, those are GraphQL mapped types used in NestJS to extend GraphQL classes. It’s kind of weird syntax, but the end result is that you can extend your graphql models and keep the decorator based metadata on the class properties. For example, you can use PartialType to make an input model that is identical to your view model, except that all the fields are optional (or nullable, in graphql terms).

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.