[BUG] - Audio does not download with video

Describe the bug Videos do not download with audio, only video.

To Reproduce Steps to reproduce the behavior: Video: https://www.youtube.com/watch?v=VWDpWmc5Yys

Expected behavior Video downloaded w/ audio

Screenshots

Environment

  ytdl_material:
    container_name: YTDL_Material
    image: tzahi12345/youtubedl-material:nightly
    volumes:
      - $DOWNLOADDIR/downloads/Youtube-dl-mat/appdata:/app/appdata
      - $DOWNLOADDIR/downloads/Youtube-dl-mat/audio:/app/audio
      - $DOWNLOADDIR/downloads/Youtube-dl-mat/video:/app/video
      - $DOWNLOADDIR/downloads/Youtube-dl-mat/subscriptions:/app/subscriptions
      - $DOWNLOADDIR/downloads/Youtube-dl-mat/users:/app/users
    environment: 
      ALLOW_CONFIG_MUTATIONS: 'true'
      ytdl_use_local_db: 'true'
      write_ytdl_config: 'true'
      UID: $PUID
      GID: $PGID
    networks:
      - isonet
    ports:
      - "8998:17442"
    restart: always

JSON attached video.info.json.zip

[dejan995]

Just to confirm that this is now working. Although I opened and linked a new issue about an error message that has started to appear after this fix.

[Tzahi12345]

@modem7 @dejan995 Thanks for the help with debugging this!

Long story short, if you selected a video quality that didn’t have the audio built in, it wouldn’t add one automatically (despite the logic being there) due to a bug. See commit here.

We’re doing something similar to MeTube with a couple differences:

• If you select a quality level, do some additional preprocessing to determine the format_id (ex. 400 or 22) and adding an audio format if one doesn’t exist (looks something like 400+172)
• If it’s left on max, we just do bestvideo+bestaudio
• For both of these approaches we add --merge-output-format mp4

Anyways it should be fixed now!