youtubedl-material_ytdl_material_1 exited with code 1

Hi

I just did a docker pull and it is crashing now. I am not sure what the issue issue is. Bear in mind that this used to work.

I am using Docker-compose on Debian Testing X64

docker-compose up                                                                                                                                                         
Creating network "youtubedl-material_default" with the default driver                                                                                                                                              
Creating youtubedl-material_ytdl_material_1 ... done                                                                                                                                                               
Attaching to youtubedl-material_ytdl_material_1                                                                                                                                                                    
ytdl_material_1  | Config items set using ENV variables.                                                                                                                                                           
ytdl_material_1  | HTTP: Started on PORT 17442                                                                                                                                                                     
ytdl_material_1  | INFO: Found new update for youtube-dl. Updating binary...                                                                                                                                       
ytdl_material_1  | (node:1) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be one of type string, Buffer, or URL. Received type object                               
ytdl_material_1  |     at Object.access (fs.js:177:10)                                                                                                                                                             
ytdl_material_1  |     at /app/app.js:680:12                                                                                                                                                                       
ytdl_material_1  |     at new Promise (<anonymous>)                                                                                                                                                                
ytdl_material_1  |     at checkExistsWithTimeout (/app/app.js:673:12)                                                                                                                                              
ytdl_material_1  |     at /app/app.js:656:23                                                                                                                                                                       
ytdl_material_1  |     at processTicksAndRejections (internal/process/task_queues.js:94:5)                                                                                                                         
ytdl_material_1  | (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise wh
ich was not handled with .catch(). (rejection id: 2)                                                                                                                                                               
ytdl_material_1  | (node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero ex
it code.                                                                                                                                                                                                           
ytdl_material_1  | /app/app.js:676                                                                                                                                                                                 
ytdl_material_1  |             watcher.close();                                                                                                                                                                    
ytdl_material_1  |                     ^                                                                                                                                                                           
ytdl_material_1  |                                                                                                                                                                                                 
ytdl_material_1  | TypeError: Cannot read property 'close' of undefined                                                                                                                                            
ytdl_material_1  |     at Timeout._onTimeout (/app/app.js:676:21)                                                                                                                                                  
ytdl_material_1  |     at listOnTimeout (internal/timers.js:531:17)                                                                                                                                                
ytdl_material_1  |     at processTimers (internal/timers.js:475:7)                 

[Tzahi12345]

Wanted to update this issue and let you guys know that the bug fix has been included in the most recent update (3.5.1)! Basically, when youtube-dl fails to update, an info message is shown and the server continues on without erroring/crashing.

Check it out here. I’m going to go ahead and close this issue. @gerroon there is still the outstanding bug where app/app.js is unable to be found on some Docker installs. I’ll keep you updated on that bug on this issue instead to avoid duplicates.

I’ll also be modifying the update process for youtube-dl in the next update (3.6) so it fails less frequently. Feel free to open a new issue if you face any other problems. Thanks for notifying me of the bug, I really appreciate it 😃

[Tzahi12345]

@radim-ek thanks for the additional logs!

Regarding the particular bug you’re facing, it has been fixed and will roll out later this week (3.5.1) under the same container version (3.5).

I’ll let you know once I push these fixes, there are a couple other things I want to work out before finalizing the update, but regardless it’ll be out soon. It’s a nasty bug so I want to get rid of it ASAP as well haha