Improve messaging when `arc` is missing on jenkins nodes
See original GitHub issueOriginal title: “FATAL: net.sf.json.JSONNull cannot be cast to java.lang.String”
context: I had a phab diff already under review. I updated it via the phab web UI by uploading a new .patch file with the latest changes.
CI bombed. Looking at the build logs I see this:
Checking out Revision 67cf3661e48c02f8a8a7df24a6714486fd760a26 (refs/remotes/origin/master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 67cf3661e48c02f8a8a7df24a6714486fd760a26
> git rev-list 67cf3661e48c02f8a8a7df24a6714486fd760a26 # timeout=10
[phabricator:harbormaster] Sending Harbormaster BUILD_URL via PHID: PHID-HMBT-utnue5zrz33sokyy3pob
[phabricator:conduit] Fetching differential from Conduit API
FATAL: net.sf.json.JSONNull cannot be cast to java.lang.String
java.lang.ClassCastException: net.sf.json.JSONNull cannot be cast to java.lang.String
at com.uber.jenkins.phabricator.conduit.Differential.getBaseCommit(Differential.java:116)
at com.uber.jenkins.phabricator.PhabricatorBuildWrapper.setUp(PhabricatorBuildWrapper.java:124)
at hudson.model.Build$BuildExecution.doRun(Build.java:156)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
at hudson.model.Run.execute(Run.java:1720)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
it seems logical that a String
could be null
… but the mechanism for achieving that translation here appears to be broken.
Issue Analytics
- State:
- Created 7 years ago
- Comments:10 (7 by maintainers)
Top Results From Across the Web
Managing Nodes - Jenkins
Configure your node to use the "Launch agents by connecting it to the master" launch method. Click Save ; Note the command required...
Read more >'Jenkins' missing node label 'master' after v. 2.307+ upgrade
Otherwise, you can go to the Dashboard -> Manage Jenkins -> Manage Nodes and Clouds, then press downwards-arrow when you hover over a...
Read more >Setting up a CI/CD pipeline w/ Jenkins, Nexus, Kubernetes
We'll use Kublr to manage our Kubernetes cluster, Jenkins, Nexus, ... If a physical node fails and volume data is lost, a new...
Read more >Untitled
... ethernet: fs_enet: Add missing MODULE_LICENSE (Michael Ellerman) - misdn: dsp: select CONFIG_BITREVERSE (Arnd Bergmann) to fix build error on ARC (Randy ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
For me it failed on differentials created from raw diffs over the phab web UI. It started to work fine once I tested with real arc diffs.
Maybe the differential coming from the web UI are missing some patch metdata and thus the error gets triggered?
Oh, that’s not good, we definetely need to provide better documentation and error messages around that.