PiranhaJava // Remove meaningless "assert" and "expect" from JUnits

Piranha simplification will need manual review and fixing of testcases, but I think it’s useful to delete lines like: expect(true).andReturn(true); assertFalse(true); which Piranha leaves behind in test classes after simplifying toggle expressions.

[ketkarameya]

This has been resolved in #156.

[mkr-plse]

This may be a slightly involved fix and it is better to avoid special casing. We will need to implement multi-pass analysis on the code to get this correct.

1. In the first pass, determine the various Piranha refactorings and their locations, but do no rewrite the code.
2. In the second pass, use the information from the previous pass along with standard Piranha refactoring to rewrite.

For the second pass to succeed in the case given above, methods expect, andReturn and anyTimes can be given as empty methodTypes as part of methodProperties.

Another option is to determine the code range that is updated by Piranha and re-run the standard Piranha analysis and restrict the refactorings to those regions.

Let us discuss more on the gitter channel before finalizing a solution.