Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Couldn't set label from component when [autoGenerate]="false"

See original GitHub issue

🐞 Bug report

Description

When I set a label with service for path chunk that was already autogenerated, it remains autogenerated and is filtered by [autoGenerate]=“false” property.

Service BreadcrumbService creates BreadcrumbDefinition with isAutoGeneratedLabel = true; It’s still autogenerated after we set label within a component.

I think we should reset isAutoGeneratedLabel if it is set by user in any time

here: https://github.com/udayvunnam/xng-breadcrumb/blob/212571fd2158fdd2baafd1b9d87e7e51f4488dd6/libs/xng-breadcrumb/src/lib/breadcrumb.service.ts#L336

🔬 Minimal Reproduction

I’ve disabled “autoGenerate” option to manually control breadcrumb labels.

<xng-breadcrumb [autoGenerate]="false" [preserveFragment]="false"></xng-breadcrumb>

My route config have not label for path chunk


{
  path: ':id',
  data: {
    breadcrumb: {
      alias: BreadcrumbAlias.wallet,
    } as BreadcrumbObject,
  },

But I’ve set a label in the component:


ngOnInit(): void {
    this.breadcrumbService.set(`@${BreadcrumbAlias.account}`, { skip: false });
    this.breadcrumbService.set(`@${BreadcrumbAlias.wallet}`, this,wallet.title);
}

Result: My breadcrumb is filtered in BreadcrumbComponent. So it’s not visible for user

💻Your Environment

Angular Version:


Angular CLI: 11.2.2
Node: 14.16.1
OS: win32 x64

Angular: 11.2.3
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Ngx-breadcrumb Version

xng-breadcrumb: 6.6.1