Keyboard shortcut for strikethrough overwrites browser shortcut for switching to right to left language layout
See original GitHub issueWhat’s the bug you are facing?
When using a tiptap editor with strikethrough nodes pressing ctrl+shift+x
results in switching to strikethrough. However this shortcut is the default for switching to a right to left language layout and back in firefox. Using it in the github editor for example changes the text input layout to provide for better input experience for hebrew and arabic and other rtl languages.
How can we reproduce the bug on our side?
Press ctrl+shift+x
in the editor on tiptap.dev
Open a comment here with firefox and press ctrl+shift+x
to see the expected behavior.
Can you provide a CodeSandbox?
tiptap.dev 😉
What did you expect to happen?
Open a comment here with firefox and press ctrl+shift+x
to see the expected behavior.
Anything to add? (optional)
I’m not sure how relevant this is. Chrome only seems to offer the switch in a browser extension. If the language settings of the browser are a rtl language this will probably also be the default for the text entry. So it’s only necessary if you want to write non-rtl text in an rtl language browser or the other way round. However this can be a frequent in a multi language environment.
I’m also not aware of any workarounds to switch the text entry direction without the keyboard shortcut - but i am also not writing rtl languages.
Just wanted to flag this as a possible issue. Feel free to close if picking a different default for the keyboard shortcut is problematic.
Did you update your dependencies?
- Yes, I’ve updated my dependencies to use the latest version of all packages.
Are you sponsoring us?
- Yes, I’m a sponsor. 💖
Issue Analytics
- State:
- Created 2 years ago
- Comments:11 (3 by maintainers)
Well
B
for bold andI
for italic are also language specific and given that these letters are also most frequently used for the corresponding buttons my intuition would still be to tryS
to toggle the third button here (screenshot taken on tiptap.dev) :About 4: plus and minus should be reserved to zoom-in/out I think, with or without modifier keys.