question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Keyboard shortcut for strikethrough overwrites browser shortcut for switching to right to left language layout

See original GitHub issue

What’s the bug you are facing?

When using a tiptap editor with strikethrough nodes pressing ctrl+shift+x results in switching to strikethrough. However this shortcut is the default for switching to a right to left language layout and back in firefox. Using it in the github editor for example changes the text input layout to provide for better input experience for hebrew and arabic and other rtl languages.

How can we reproduce the bug on our side?

Press ctrl+shift+x in the editor on tiptap.dev Open a comment here with firefox and press ctrl+shift+x to see the expected behavior.

Can you provide a CodeSandbox?

tiptap.dev 😉

What did you expect to happen?

Open a comment here with firefox and press ctrl+shift+x to see the expected behavior.

Anything to add? (optional)

I’m not sure how relevant this is. Chrome only seems to offer the switch in a browser extension. If the language settings of the browser are a rtl language this will probably also be the default for the text entry. So it’s only necessary if you want to write non-rtl text in an rtl language browser or the other way round. However this can be a frequent in a multi language environment.

I’m also not aware of any workarounds to switch the text entry direction without the keyboard shortcut - but i am also not writing rtl languages.

Just wanted to flag this as a possible issue. Feel free to close if picking a different default for the keyboard shortcut is problematic.

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:11 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
max-nextcloudcommented, Jul 7, 2022

The problem with s for “Strikethrough” isThe problem with s for “Strikethrough” is that it’s English specific, while x could be a more internationally recognized symbol for suppression?

Well B for bold and I for italic are also language specific and given that these letters are also most frequently used for the corresponding buttons my intuition would still be to try S to toggle the third button here (screenshot taken on tiptap.dev) :

Bildschirmfoto von 2022-02-26 15-12-13

1reaction
cadarscommented, Feb 26, 2022

About 4: plus and minus should be reserved to zoom-in/out I think, with or without modifier keys.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Switch between languages using the Language bar
Keyboard shortcut : To switch between keyboard layouts, press Alt+Shift. Note: The icon is just an example; it shows that English is the...
Read more >
3 Strikethrough Shortcuts in Microsoft Word to Cross Out Text
Using keyboard shortcuts to access the Font dialog box · Select the text you want to strikethrough. · Press Ctrl + D. The...
Read more >
Add right-to-left text – Figma Help Center
Change the direction of RTL text in a Figma design file from the right sidebar, quick actions menu, or main menu. Right sidebar:...
Read more >
Keyboard shortcuts | Docs - TinyMCE
Add custom shortcuts to TinyMCE. Important: Adding a custom shortcut with a keyboard combination that conflicts with an existing TinyMCE or browser shortcut...
Read more >
Epic Keyboard Shortcuts
Highlight one character to left of cursor. Page 6. Shortcut. Action. CTRL+SHIFT+RI. GHT ARROW.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found