Run pylint on everything

We should run pylint on everything. For easy automatic checking, every file should have 10/10 score. To achieve this, you may have to locally disable some warnings (# pylint: disable=...) – use this only if it is really necessary. After you eliminate all errors and warnings, add this line to the file:

# tests: lint

All files containing this line are checked with pylint by lint_run.sh, which you should always run before you commit anything and which is automatically run on Travis CI after you push to Github.

You can see the list of files that have not been checked yet with test_status.sh. This issue will be closed when that list is empty.

[tomasmcz]

I’m not sure that can be done in a reasonable way, because there is no option for pylint to ignore comments with local disable commands. We would have to disable a lot of warnings globally in the configuration that is checked automatically and that is against the goal of this proposal. Even with too-many-branches, you should review your code before pushing it to master and think really hard whether there is any more elegant way to do it. And if there is not, then you should write the comment that locally disables the warning, meaning “yes, I really thought this through and I want 50 branches in this function”. And you have to do that right then, because I can guarantee that you will not get back to it later and fix something just because it has lower pylint score. And even if you did, it would be much more unnecessary work.

You will still see a pylint info statement about the local ignore in the pylint output, so can easily judge what file is the worst (I’m thinking train.py at the moment) even without a numerical score.

Python is a terrible language and any way to consistently limit its dreadful anarchy must be used to the fullest extent!

[jindrahelcl]

This is far from done yet, why did you close it?