Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow lang-files placed relative to package.manifest

See original GitHub issue

A brief description of your feature request goes here.

Umbraco 8 allows for manifest files to be placed “where ever” under app_plugins like App_Plugins/Plugin/Feature1/f1.manifest and App_Plugins/Plugin/Feature2/f2.manifest and so forth.

You could then build a plugin that can have multiple features.

Lang-files on the other hand can only live in one place – App_Plugins/Plugin/Lang/*.xml

From our own part of the woods, we a building a lot of internal stuff that we reuse, and instead of having 20-30 Company.This.That and Company.Some.Thing folders, we would like to have:

App_Plugins/Company/This/That and App_Plugins/Company/Some/Thing - and have lang-files in subfolders, together with the respective manifest files

How can you help?

https://github.com/umbraco/Umbraco-CMS/pull/4454 expanded the name of the lang files resolved. This could easily be changed to look for xml files in lang folder :

appPlugins
    .GetDirectories("lang", SearchOption.AllDirectories)
    .SelectMany(x => x.GetFiles("*.xml", SearchOption.TopDirectoryOnly))

Another aspect of this could be to allow a “lang”-setting in the package manifest.

{
    "lang": ["~/App_Plugins/Company/This/That/lang"],
    "propertyEditors": [],
    "gridEditors": [],
    "parameterEditors": [],
    "javascript": ["~/App_Plugins/Company/This/That/js/controllers.js"],
    "css": []
}

What would people prefer? Expanding the searching to include subfolders, or implement lang-property in manifest?