Media picker deleted item not shown correctly
See original GitHub issueAfter deleting a media item (moving it to the recycle bin), the item is correctly shown in a Media picker property like this:
But after emptying the recycle bin, the preview/thumbnail completely breaks:
- The file extension label only displays a dot
- The localization key
mediaPicker_deletedItem
doesn’t exist - The icon isn’t completely visible because of the ‘Trashed’ label
- It’s still possible to click on the edit icon/link, opening a dialog, show an error notification (
Request error: The URL returned a 404 (not found)
) and not having a way to close the dialog, having to refresh the page: possibly losing unsaved changes!
Reproduction
Specifics
Umbraco 8.1.4
This is somewhat related to https://github.com/umbraco/Umbraco-CMS/issues/3381, so this might also be the case on Umbraco 7.
Steps to reproduce
- Add an image
- Pick the image in a Media picker
- Completely delete the picked image
Expected result
I would expect at least the following:
- Hide the file extension/dot and edit icon/link
- Add the localized ‘mediaPicker_deletedItem’ message, e.g. ‘This media item is deleted’
Because of the added message, the icon is pushed up, so it’s more visible. And maybe the ‘Trashed’ label can also be changed to ‘Deleted’?
All these changes are only about how deleted media items are displayed, but as you can’t restore the media item, the only action is removing it from the picked items. And if multiple items are picked and deleted, both the thumbnails look exactly the same (as there’s no preview/name to display). The only reason for showing deleted items will be to inform editors something was previously picked and not available anymore… Are there better ways to show this and should we be able to remove multiple trashed/deleted items in a single action (e.g. after the ‘You have picked a media item currenly deleted or in the recycle bin’)?
Issue Analytics
- State:
- Created 4 years ago
- Comments:7 (5 by maintainers)
Sure that should definitely look a bit better than it does now.
Note that we’re working on the media tracking features soon that might overlap with your other suggestions.
Hiya @ronaldbarendse,
Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.
We will close this issue for now but we’re happy to open it up again if you think it’s still relevant (for example: it’s a feature request that’s not yet implemented, or it’s a bug that’s not yet been fixed).
To open it this issue up again, you can write
@umbrabot still relevant
in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it’s still relevant.For example:
This will reopen the issue in the next few hours.
Thanks, from your friendly Umbraco GitHub bot 🤖 🙂