question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Media picker deleted item not shown correctly

See original GitHub issue

After deleting a media item (moving it to the recycle bin), the item is correctly shown in a Media picker property like this:

Trashed media

But after emptying the recycle bin, the preview/thumbnail completely breaks:

Deleted media

  • The file extension label only displays a dot
  • The localization key mediaPicker_deletedItem doesn’t exist
  • The icon isn’t completely visible because of the ‘Trashed’ label
  • It’s still possible to click on the edit icon/link, opening a dialog, show an error notification (Request error: The URL returned a 404 (not found)) and not having a way to close the dialog, having to refresh the page: possibly losing unsaved changes!

Reproduction

Specifics

Umbraco 8.1.4

This is somewhat related to https://github.com/umbraco/Umbraco-CMS/issues/3381, so this might also be the case on Umbraco 7.

Steps to reproduce

  • Add an image
  • Pick the image in a Media picker
  • Completely delete the picked image

Expected result

I would expect at least the following:

  • Hide the file extension/dot and edit icon/link
  • Add the localized ‘mediaPicker_deletedItem’ message, e.g. ‘This media item is deleted’

Deleted media - expected

Because of the added message, the icon is pushed up, so it’s more visible. And maybe the ‘Trashed’ label can also be changed to ‘Deleted’?

All these changes are only about how deleted media items are displayed, but as you can’t restore the media item, the only action is removing it from the picked items. And if multiple items are picked and deleted, both the thumbnails look exactly the same (as there’s no preview/name to display). The only reason for showing deleted items will be to inform editors something was previously picked and not available anymore… Are there better ways to show this and should we be able to remove multiple trashed/deleted items in a single action (e.g. after the ‘You have picked a media item currenly deleted or in the recycle bin’)?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
nul800sebastiaancommented, Sep 19, 2019

Sure that should definitely look a bit better than it does now.

Note that we’re working on the media tracking features soon that might overlap with your other suggestions.

0reactions
umbrabotcommented, Mar 4, 2021

Hiya @ronaldbarendse,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we’re happy to open it up again if you think it’s still relevant (for example: it’s a feature request that’s not yet implemented, or it’s a bug that’s not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it’s still relevant.

For example:

@umbrabot still relevant This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Read more comments on GitHub >

github_iconTop Results From Across the Web

media picker files not showing #4960
Hello , i'm posting this a an issue because it used to work fine in general i have a table named events with...
Read more >
flutter - file_picker - onPressed does not delete a card ...
1 Answer. The problem here is that the paths variable is made up of a list of PlatformFile and you are trying to...
Read more >
Media Picker can't write true location android and UWP ...
When I use the media picker to write the location of the photo file, it works but the photo file is redirected to...
Read more >
media picker issue - Templates and document types
I am using the standard Media Picker in several document types and for most of ... There are no errors and it is...
Read more >
images disappeared after upgrade to 25 - Digibiz Advanced ...
I am getting this error on every page which has empty DAMP items, so in the above example on node 1092 i can...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found