u8 Migration: ConvertTinyMceAndGridMediaUrlsToLocalLink fails on Umbraco 8.6.0

Although measures have been taken to ensure the queries for generating the sql to read the property details using the PropertyTypeDto80 and friends works to exclude the version 8.6 columns mandatoryMessage and validationRegExpMessage, line 105 in ConvertTinyMceAndGridMediaUrlsToLocalLink.cs below still queries the new columns:

var media = _mediaService.GetMediaByPath(href);

I’m wondering whether the best way to fix this is to move the Migration AddPropertyTypeValidationMessageColumns higher up in UmbracoPlan so it’s done earlier…

Umbraco version

I am seeing this issue on Umbraco version: 8.6

Reproduction

Bug summary

See above - note also that I’ve included the patches from PR #6191 to significantly speed up the migration.

Specifics

• Umbraco 8.6.0 patched with PRs related to #6191

Steps to reproduce

Expected result

Actual result

[nul800sebastiaan]

Now it makes a lot more sense, 8.6… 😅

[umbrabot]

Hiya @robertjf,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we’re happy to open it up again if you think it’s still relevant (for example: it’s a feature request that’s not yet implemented, or it’s a bug that’s not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it’s still relevant.

For example:

@umbrabot still relevant This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂