umb-overlay inside umb-editor is hidden
See original GitHub issueWe’re using some “Nested Nested Content” inside Doc Type Grid Editor, this works fine until there is more than one Document Type configured on the Nested Content Data Type. In these cases a “umb-overlay” is shown so that the editor can pick which DocType to add, like this:
This works all fine, but when Nested Content is shown inside a EditorService-dialog, the umb-overlay will set it’s style to left:xxx px; so that it ends up outside the screen, this is how it looks when clicking “Add Content”
After removing the “left”-style from the umb-overlay the box shows again:
This issue is present only with “Doc Type Grid Editor” but also when for example configuring a “Multi Node Tree Picker” to have the “Open”-button. When opening an Node and trying to choose a DocType for Nested Content it looks like this:
In other words, the umb-overlay is placed to much to the right so that the editor can’t choose a DocType. The issue is specially big when the editorService is opening a window that is of type “small”.
We’ve solved this with some CSS-hacks but I guess it would be good to come up with something in Core?
Our solution was to put any umb-overlays to the right using CSS like this but there might be better solutions =D
.umb-editors {
.umb-overlay {
left: inherit !important;
right: 0 !important;
top: 0 !important;
bottom: 0 !important;
}
}
Issue Analytics
- State:
- Created 4 years ago
- Comments:11 (10 by maintainers)
I’ve shared a “fix” that works for us here https://github.com/umbraco/Umbraco-CMS/issues/7918#issuecomment-625982546 and maybe it could be a starting point for something to ship in core.
@stefankip Yes and no.
It’s the same underlying problem, but my PR only fixes this for the grid overlay only, as it doesn’t fix the problem with the
umb-overlay
directive, but instead replaces the use of the directive with the neweroverlayService
.I can’t really remember for sure whether the problem was also fixed generally for the
umb-overlay
directive. If not, it would be useful as it would fix the problem globally for the directive. And it may be a lot quicker than replacing all uses ofumb-overlay
withoverlayService
.