v8: DB TableBuilder can't handle Currency field types

I’ve created a migration plan that attempts to create some DB tables using the TableBuilder helpers and for one of the columns I need it to be a currency field. Now, I can do the following:

Create.Table("myTableName")
    .WithColumn("price").AsCurrency().NoNullable()
    .Do()

And all of this is valid code (it compiles). However, when the Do() is executed it throws an exception. The exeception is a bit vague, but I’ve ultimately narrowed it down to the TableBuilder being unable to find a type for DbType.Currency in the SqlSyntaxProviders DbTypeMap collection.

Ultimately then, the SqlSyntaxProvider.DbTypeMap collection needs updating to hold a type map for the DbType.Currency type.

[mattbrailsford]

@dampee decimal is fine, I’ve done a workaround for now using .AsDecimal(19, 4) which seems to be the common accuracy for money. The point of this issue is that if you use .AsCurrency() you’ll get an error because there is no mapping for it. I don’t mind what it maps to, it just needs to map to something 😁

[nul800sebastiaan]

This issue has been in the up for grabs state for quite a while now and it seems nobody is ready to pick this one up.

For now we’ll close this issue to prevent the list of up for grabs from becoming very stale. We’re happy to re-open it if someone still thinks it’s good to work on this.

If anyone is about to pick this issue up to fix it, make sure to test first if you can reproduce the problem in the latest version before you start to work on it.

Thanks! Sebastiaan on behalf of Umbraco HQ.