question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

V8: Grid layout editorService dialogs close row settings dialog

See original GitHub issue

Hi, When you try to open any editorService-editor (i.e. contentPicker, mediaPicker) from the row-settings dialog it will show a blur over the opened dialog. You can click this blur away but as soon as you close the mediaPicker (with editorService.close()), it will also close the row-settings dialog. This causes the image to never be saved. Please look at this gif for a visual representation (note the blur when the mediaPicker opens): mediapicker3

The code i use within the row-settings dialog looks like :

$scope.addImage = function () {
    editorService.mediaPicker({
        onlyImages: true,
        multiPicker: false,
        submit: function (item) {
            // do stuff
            editorService.close();
        },
        close: function () {
            editorService.close();
        }
    });
};

When you open another dialog, Umbraco renders a second div with class “umb-overlay-backdrop”. This overlay renders in front of the media picker, which will make it unclickable. I hacked the backdrop to never show, which fixes the issue, but is not the solution. .umb-overlay-backdrop { display: none !important; }

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:3
  • Comments:10 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
mecographcommented, Oct 2, 2019

@marcoteodoro here you go:

var options = {
     title: "Edit settings",
     view: "/App_Plugins/ListBoxStatic/assets/editSettings.html",
     size: "small",
     data: data,
     submit: (response) => {
          // do sth with response
          editorService.close();
     },
     close: () => editorService.close()
};
editorService.open(options);
0reactions
umbrabotcommented, Feb 2, 2021

Hiya @Lars-OJ,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we’re happy to open it up again if you think it’s still relevant (for example: it’s a feature request that’s not yet implemented, or it’s a bug that’s not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it’s still relevant.

For example:

@umbrabot still relevant This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Read more comments on GitHub >

github_iconTop Results From Across the Web

editorService.mediapicker in angular - Umbraco 8
When I call editorService.close(); both dialogs are closed. It seems to me that the mediaPicker-dialog replaces the one the grid-layout editor ...
Read more >
How to present a row of a repeating layout as a modal dialog
Click OK to save the settings and close the dialog. The control Parameters dialog re-appears. Click OK to close the dialog. How to...
Read more >
March 28, 2019, 4:41 am - ActiveTopics - RSSing.com
I'm building a custom grid editor and need to use the dialogService to open up, well, a dialog, so that the user can...
Read more >
How to present a row of a repeating layout as a modal dialog
Click OK to save the settings and close the dialog. The control Parameters dialog re-appears. Click OK to close the dialog. How to...
Read more >
CDS/Dynamics CRM Source component
The CRM Source Component is an SSIS data flow pipeline component that can be used to read/retrieve data from the Microsoft Dynamics CRM...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found