Variant Children of non-variant node are not listed

Testing and PR notes: https://github.com/umbraco/Umbraco-CMS/issues/5886#issuecomment-513100527

---

Release 8.1.0 includes some breaking changes regarding IPublishedContent.Children() - gone - and its replacement properties .Children and .ChildrenForAllCultures (see this discussion). But it looks like the implementation does not work as expected:

If you have a non-variant parent with a mix of culture-variant and non-variant children:

• Only the non-variant children are listed in the Children property.
• The culture-variant children are not listed, even if they have a published version in the current language.
• The related methods .FirstChild() , .FirstChild<T>(), etc. also fail to retrieve any culture-variant children.

The only way to access the culture-variant children is the ChildrenForAllCultures property. I don’t think this is by design, is it?

---

This item has been added to our backlog AB#1721

[Shazwazza]

Here’s a PR https://github.com/umbraco/Umbraco-CMS/pull/5946

The problem was the odd logic in PublishedContentExtensions.Children where it did this:

            // invariant has invariant value (whatever the requested culture)
            if (!content.ContentType.VariesByCulture() && culture != "*")
                culture = "";

I’m actually unsure why this logic exists and it may actually be a copy/paste problem. This similar logic exists in the Name and UrlSegment methods but in those methods it makes sense since they are returning single values. Perhaps @zpqrtbnk has some thoughts on that.

You can see in the PR that I’ve removed this logic which fixes these issues. I’ve added unit tests to prove this (these were failing before adding the fix). Please also have a look at the code comments/notes I’ve added.

For testing:

• Follow these steps https://github.com/umbraco/Umbraco-CMS/issues/5886#issuecomment-511585905
• Create a tree structure in the back office with variant -> invariant -> variant and navigate to the deepest variant and ensure that it’s URLs are generated and it can be routed to

[JoseMarcenaro]

@brahim19 - please open a thread in https://our.umbraco.com/forum/ to get help on this issue with your code, as it is not an Umbraco issue. Thx