[BUG] FSM not compatible with disabled domain reload

Describe the bug Variables use OnEnable to reset themselves

However, Unity does not call OnEnable on scriptable objects when entering playmode IFF:

• the ScriptableObject is already loaded
• domain reload on play is disabled

To Reproduce Steps to reproduce the behavior:

1. Disable Domain Reload
2. Create any variable
3. Change the variable value during play mode
4. Value will be preserved on next play mode

Expected behavior Variables should reset to initial value for every play mode sessions

Additional context My current hack

using UnityAtoms;
using UnityEditor;
using UnityEngine;

namespace Atoms.Editor.EnsureVarReset
{
  // ensure class initializer is called whenever scripts recompile
  [InitializeOnLoad]
  public static class EnsureVarReset
  {
    // register an event handler when the class is initialized
    static EnsureVarReset()
    {
      // Whenever the game enters or leaves playmode
      EditorApplication.playModeStateChanged += LogPlayModeState;
    }

    static void LogPlayModeState(PlayModeStateChange state)
    {
      // Reset each loaded variable
      foreach (AtomBaseVariable variable in ScriptableObject.FindObjectsOfType<AtomBaseVariable>())
      {
        // Reset the var
        variable.Reset();
      }
    }
  }
}

[soraphis]

Not necessarily a warning, just enough any diagnostic logs

if you wanna elaborate on that topic or bring up implementation ideas that could solve that without harming performance or other implementations, feel free to do so, But I’d ask you, to do so in #323 (feel free to re-open the ticket if necessary!)

[soraphis]

what is considered “incorrect state”? that’s business logic, only you can decide about that and you could write an validator for that.

modifying the FSM implementation to throw errors in that case, would force you to setup every possible transition.

let’s say you feed your keyboard input as actions into your FSM to handle your game state WORLD —ESC—> MENU WORLD — I —> INVENTORY …

that way you only handle transitions and every key that is not a transition is a “stay in state”. works perfectly fine, but does not work anymore (or would spam warnings) if #323 would be implemented.

the issue in this case is less that the FSM does not throw warnings, the issue is more that the FSM was able to be in an invalid starting state that was seemingly not visible in the inspector (as you had to resolve to the debug inspector)