When a client connects to a server all clients receive all NetworkVariables

Thanks @mraue for the update. I get your issue now. Please let me update it and re-open as it seems pretty important.

Description

Every time a client connects to a server all NetworkVariables on all NetworkObjects get synced to all clients.

Reproduce Steps

1. Create a NetworkObject with a NetworkVariable. Add a log that tracks OnValueChanged
2. Start a server and connect a client
3. Connect a second client
4. The first and the second client show the OnValueChanged log

Actual Outcome

All connected clients receive a NetworkVariable update.

Expected Outcome

Only the second client connecting should receive the NetworkVariable data.

Additional Context

During the internal void SendSpawnCallForObject(ulong clientId, NetworkObject networkObject) for the NetworkObject to spawn, we mark: networkObject.MarkVariablesDirty(true); This causes the NetworkVariable to be considered dirty for all clients. As a result, the NetworkVariable gets serialized to all clients. The difficulty lies with the fact that current Netcode for GameObjects doesn’t have a way to mark dirtiness for some clients only. This will require a bit of refactor.

[mraue]

I tested commenting out the line networkObject.MarkVariablesDirty(); inSendSpawnCallForObject. While the initial spawning works fine, the spawning triggered by visibility changes is then broken. The objects do not receive the NetworkVariable states.

[LukeStampfli]

More details can also be found in the Discord conversation here